Skip to content

Conversation

@ppadti
Copy link
Contributor

@ppadti ppadti commented Dec 15, 2025

Description

This PR aims to add new performance filter to the BFF.

How Has This Been Tested?

  1. Run the application in mock model
curl -s -H "kubeflow-userid: user@example.com" \
  "http://localhost:4000/api/v1/model_catalog/sources/sample-source/performance_artifacts/repo1%2Fgranite-8b-code-instruct?namespace=kubeflow" 
  1. With kind cluster and port-forwarding, we might have to have performance data to get a response.
    run the above curl cmd with respective sourceID and modelName

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: ppadti <ppadti@redhat.com>
@ppadti ppadti force-pushed the performance-endpoint branch from b9bc41e to 0cc38e6 Compare December 15, 2025 16:02
@ederign
Copy link
Member

ederign commented Dec 15, 2025

/assign

@ederign
Copy link
Member

ederign commented Dec 15, 2025

@ppadti, can you please take a look at the test failure?

@ppadti
Copy link
Contributor Author

ppadti commented Dec 16, 2025

@ppadti, can you please take a look at the test failure?

yeah, its a flaky test, failing on most of the PR - I have reported that to the backend team.

@ppadti
Copy link
Contributor Author

ppadti commented Dec 16, 2025

/retest

@google-oss-prow google-oss-prow bot added the lgtm label Dec 16, 2025
@ederign
Copy link
Member

ederign commented Dec 16, 2025

/approve
/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7f5f515 into kubeflow:main Dec 16, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants