-
Notifications
You must be signed in to change notification settings - Fork 151
fix: deprecate description to version_description #2007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deprecate description to version_description #2007
Conversation
|
/ok-to-test |
|
/test |
|
@jonburdo: No presubmit jobs available for kubeflow/model-registry@main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test ? |
|
@nunoferna: No presubmit jobs available for kubeflow/model-registry@main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@tarilabs @Al-Pragliola We may need one of you to approve the test runs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small things to fix. Otherwise this looks great!
I'm hoping we can get the tests approved to run soon :)
I did try this out locally and ran the tests myself though, and it works as expected.
|
/ok-to-test |
5bf386e to
b10f490
Compare
Fixes kubeflow#1284 Signed-off-by: Nuno Fernandes <nuno.o.fernandes@outlook.pt>
4c70e13 to
03e87fc
Compare
|
/retest |
|
/ok-to-test |
jonburdo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting close!
The async-job test failure happens because we are installing a release of model-registry python client rather than using the current state of the repo. I think the best thing to do for now is to treat it as a separate component and revert those changes for now. We can update it later after a release of the python client.
Something like:
git fetch upstream
git restore jobs/async-upload/ --source=upstream/main
03e87fc to
4446e91
Compare
Signed-off-by: Nuno Fernandes <nuno.o.fernandes@outlook.pt>
Signed-off-by: Nuno Fernandes <nuno.o.fernandes@outlook.pt>
4446e91 to
e3f0398
Compare
tarilabs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you very much @nunoferna for your contributions
and for @jonburdo for the guidance
great teamwork!
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1284
Description
descriptionparameter in favor ofversion_descriptionwhen registering models / HF models.DeprecationWarningis emitted and the value is used as version_description when the new parameter is not set.version_description.version_descriptioninstead ofdescription.How Has This Been Tested?
Python client unit tests: cd clients/python && make test-e2e-run
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes