Skip to content

Conversation

@nunoferna
Copy link
Contributor

@nunoferna nunoferna commented Dec 15, 2025

Fixes #1284

Description

  • Deprecates the Python client description parameter in favor of version_description when registering models / HF models.
  • Preserves backwards compatibility: if description is provided, a DeprecationWarning is emitted and the value is used as version_description when the new parameter is not set.
  • Updates Python client tests and async-upload job tests/integration tests to use version_description.
  • Updates documentation/examples to use version_description instead of description.

How Has This Been Tested?

Python client unit tests: cd clients/python && make test-e2e-run

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@pboyd
Copy link
Member

pboyd commented Dec 16, 2025

/ok-to-test

@jonburdo
Copy link
Member

/test

@google-oss-prow
Copy link

@jonburdo: No presubmit jobs available for kubeflow/model-registry@main

Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunoferna
Copy link
Contributor Author

/test ?

@google-oss-prow
Copy link

@nunoferna: No presubmit jobs available for kubeflow/model-registry@main

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jonburdo
Copy link
Member

@tarilabs @Al-Pragliola We may need one of you to approve the test runs

Copy link
Member

@jonburdo jonburdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small things to fix. Otherwise this looks great!

I'm hoping we can get the tests approved to run soon :)
I did try this out locally and ran the tests myself though, and it works as expected.

@tarilabs
Copy link
Member

/ok-to-test

@nunoferna nunoferna force-pushed the fix/deprecate-description branch from 5bf386e to b10f490 Compare December 17, 2025 12:50
Fixes kubeflow#1284
Signed-off-by: Nuno Fernandes <nuno.o.fernandes@outlook.pt>
@nunoferna nunoferna force-pushed the fix/deprecate-description branch 2 times, most recently from 4c70e13 to 03e87fc Compare December 17, 2025 13:36
@jonburdo
Copy link
Member

/retest

@jonburdo
Copy link
Member

/ok-to-test

Copy link
Member

@jonburdo jonburdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting close!

The async-job test failure happens because we are installing a release of model-registry python client rather than using the current state of the repo. I think the best thing to do for now is to treat it as a separate component and revert those changes for now. We can update it later after a release of the python client.

Something like:

git fetch upstream
git restore jobs/async-upload/ --source=upstream/main

@nunoferna nunoferna force-pushed the fix/deprecate-description branch from 03e87fc to 4446e91 Compare December 17, 2025 17:54
Signed-off-by: Nuno Fernandes <nuno.o.fernandes@outlook.pt>
Signed-off-by: Nuno Fernandes <nuno.o.fernandes@outlook.pt>
@nunoferna nunoferna force-pushed the fix/deprecate-description branch from 4446e91 to e3f0398 Compare December 17, 2025 18:43
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much @nunoferna for your contributions
and for @jonburdo for the guidance
great teamwork!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a881740 into kubeflow:main Dec 18, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Client] Description not populating

4 participants