fix(backend): Use KFP_POD_NAME in PVC creation #12499
Open
+1,167
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
This PR adds
commonEnvsto the driver container. This will now expose theKFP_POD_NAMEandKFP_POD_UIDenv vars. This PR then updatesInPodNameto take advantage ofKFP_POD_NAMEto accurately get the full pod name without the 63 char truncation issue seen when using hostname (seen in issue #12350)This supersedes #12351, which attempted to address this issue but was not properly tested. After deploying that change, it was discovered it did not work as expected, due to the
ARGO_POD_NAMEenv var not being exposed in the main container. This PR contains the correct implementation and has been validated in a live cluster.Testing Evidence:
Using the following pvc hello world file with a long pipeline name:
KFP_POD_NAMEexposed in main containerPassing Pipeline:

Checklist: