Skip to content

Conversation

@KhizerRehan
Copy link
Contributor

@KhizerRehan KhizerRehan commented Sep 22, 2025

What this PR does / why we need it:
This PR upgrades the Angular framework and related dependencies from version 19 to version 20, along with updating Material Design component CSS custom properties from the deprecated --mdc-* prefix to the new --mat-* prefix.

Which issue(s) this PR fixes:

Fixes #7685

What type of PR is this?

Special notes for your reviewer:

  • Material Component variables names has been updated therefore have to manually update --mdc-* prefix to the new --mat prefix along with variable names

Does this PR introduce a user-facing change? Then add your Release Note here:

Upgrade to Angular 20 with Material Design CSS prefix migration from --mdc-* to --mat-*

Documentation:

NONE

@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Sep 22, 2025
@KhizerRehan
Copy link
Contributor Author

/test all

@kubermatic-bot kubermatic-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 22, 2025
@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.89%. Comparing base (cedce4b) to head (8f3d0d4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7601      +/-   ##
==========================================
- Coverage   44.92%   44.89%   -0.03%     
==========================================
  Files         443      443              
  Lines       19889    19901      +12     
  Branches     2772     2774       +2     
==========================================
  Hits         8935     8935              
- Misses      10951    10963      +12     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KhizerRehan
Copy link
Contributor Author

/test all

@KhizerRehan
Copy link
Contributor Author

/test all

1 similar comment
@KhizerRehan
Copy link
Contributor Author

/test all

@KhizerRehan
Copy link
Contributor Author

/test all

@KhizerRehan KhizerRehan changed the title WIP: Angular Upgrade v20 Angular Upgrade v20 Nov 20, 2025
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). and removed do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 20, 2025
@KhizerRehan KhizerRehan marked this pull request as ready for review November 20, 2025 11:21
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2025
@KhizerRehan
Copy link
Contributor Author

/test pre-dashboard-web-integration-tests-ce

@kubermatic-bot
Copy link
Contributor

@KhizerRehan: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pre-dashboard-validate-prow-yaml

Use /test all to run all jobs.

In response to this:

/test pre-dashboard-web-integration-tests-ce

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@KhizerRehan
Copy link
Contributor Author

/test pre-dashboard-web-integration-tests-ce

@kubermatic-bot
Copy link
Contributor

@KhizerRehan: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pre-dashboard-validate-prow-yaml

Use /test all to run all jobs.

In response to this:

/test pre-dashboard-web-integration-tests-ce

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@ahmadhamzh ahmadhamzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems good, I only noticed this background-color difference on all scrollable pages.

Image

@KhizerRehan
Copy link
Contributor Author

All seems good, I only noticed this background-color difference on all scrollable pages.

Image

can you add comparison image with dev / local if you are already doing test in my branch @ahmadhamzh

@ahmadhamzh
Copy link
Contributor

on dev:
image

on the local branch:
Image

also the notification message style
image

Copy link
Contributor

@ahmadhamzh ahmadhamzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2025
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ba490e55c58dd88c0b1054fcdcd5251817d610fe

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmadhamzh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2025
@kubermatic-bot kubermatic-bot merged commit 96d25f2 into main Dec 8, 2025
9 of 10 checks passed
@kubermatic-bot kubermatic-bot deleted the upgrade-v20 branch December 8, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to Angular 20

4 participants