Skip to content

Conversation

@jsafrane
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Update OpenTelemetry libs to 1.38 and remove deprecated otelgrpc.UnaryClientInterceptor call that is not available there.

See kubernetes-csi/external-attacher#690 for update failures without this PR.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

The call is not available in newer OpenTelemetry update.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 25, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 25, 2025
@jsafrane
Copy link
Contributor Author

@Fricounet can you please review this? I haven't found any connection.WithOtelTracing() calls anywhere.

Copy link
Contributor

@Fricounet Fricounet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I intially implemented the withOtelTracing call so that it would be easy to enable otel tracing on this CSI sidecars but I never got the time to implement it and since now, most CSI drivers plugin support tracing on their side, having it on the sidecar's would be a bit redundant. So I'm not really surprised that nothing uses connection.withOtelTracingin this repo at least

I probably can't approve though since I'm not part of sig-storage 😅

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fricounet, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@carlory
Copy link
Member

carlory commented Nov 26, 2025

I probably can't approve though since I'm not part of sig-storage

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit 257b781 into kubernetes-csi:master Nov 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants