Integrate disk support labels into NodeGetInfo #2199
Merged
+213
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
Contributor
Author
|
/test all |
k8s-ci-robot
added
the
size/L
Contributor
|
/assign @tonyzhc |
hajiler
force-pushed
the
gv-node-ge-info-branch
branch
from
a2ec1ec to
6fbd415
Compare
k8s-ci-robot
added
size/M
hajiler
force-pushed
the
gv-node-ge-info-branch
branch
from
6fbd415 to
02c19b1
Compare
k8s-ci-robot
added
size/L
hajiler
force-pushed
the
gv-node-ge-info-branch
branch
2 times, most recently
from
60a5117 to
e1d3d24
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
cemakd
reviewed
Nov 5, 2025
hajiler
force-pushed
the
gv-node-ge-info-branch
branch
from
e1d3d24 to
46f0aef
Compare
k8s-ci-robot
added
the
needs-rebase
hajiler
force-pushed
the
gv-node-ge-info-branch
branch
from
46f0aef to
9776c74
Compare
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
needs-rebase
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cemakd, hajiler, mattcary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR is a pre-requisite for the generic volumes feature. It adds disk types supported by a node to the topology information using NodeGetInfo. The PR will be followed up by using this topology information to select a compatible disk type when provisioning a volume.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Node attach limit override and the disk type labels rely on reading the Node k8s object. Instead of repeating this request, I migrated it out to NodeGetInfo and piped down the Node object. This also allowed me to add more comprehensive unit testing.
Does this PR introduce a user-facing change?: