-
Couldn't load subscription status.
- Fork 168
bump cloudbuild docker image #2212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump cloudbuild docker image #2212
Conversation
release-tools/cloudbuild.yaml
Outdated
| # the desired version of Go (currently defined in release-tools/prow.sh), | ||
| # but that just speeds up the build and is not required. | ||
| - name: 'gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20210917-12df099d55' | ||
| - name: "gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to change to latest or we can keep it as a fixed newer version to fix post submit?
Latest can change any time, so past builds become impossible to reproduce.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pinned to the most recent build.
0cc7e8d to
c51ebd5
Compare
|
@upodroid: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Can we get this merged, a new tag cut and images promoted please? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sunnylovestiramisu, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Do you just want a new version instead of cherry-pick to previous branches? |
|
Have one more question, unhold when you think it is not an issue: /hold |
| - PULL_BASE_REF=${_PULL_BASE_REF} | ||
| - REGISTRY_NAME=gcr.io/${_STAGING_PROJECT} | ||
| - HOME=/root | ||
| - GIT_TAG=${_GIT_TAG} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the space for the following 4 lines be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's the yaml linter fixing some spaces
A new version is fine. /hold cancel |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The postsubmits have been broken for a long time. This should fix it.
https://prow.k8s.io/job-history/gs/kubernetes-ci-logs/logs/post-gcp-compute-persistent-disk-csi-driver-push-images
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: