Skip to content

Conversation

@upodroid
Copy link
Member

@upodroid upodroid commented Oct 27, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

The postsubmits have been broken for a long time. This should fix it.

https://prow.k8s.io/job-history/gs/kubernetes-ci-logs/logs/post-gcp-compute-persistent-disk-csi-driver-push-images

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Oct 27, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2025
@upodroid
Copy link
Member Author

/cc @mattcary @msau42

# the desired version of Go (currently defined in release-tools/prow.sh),
# but that just speeds up the build and is not required.
- name: 'gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20210917-12df099d55'
- name: "gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change to latest or we can keep it as a fixed newer version to fix post submit?
Latest can change any time, so past builds become impossible to reproduce.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pinned to the most recent build.

@upodroid upodroid force-pushed the bump-ci-docker-image branch from 0cc7e8d to c51ebd5 Compare October 28, 2025 12:36
@k8s-ci-robot
Copy link
Contributor

@upodroid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e-arm c51ebd5 link false /test pull-gcp-compute-persistent-disk-csi-driver-e2e-arm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@upodroid
Copy link
Member Author

Can we get this merged, a new tag cut and images promoted please?

@sunnylovestiramisu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sunnylovestiramisu, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2025
@sunnylovestiramisu
Copy link
Contributor

Can we get this merged, a new tag cut and images promoted please?

Do you just want a new version instead of cherry-pick to previous branches?

@sunnylovestiramisu
Copy link
Contributor

sunnylovestiramisu commented Oct 28, 2025

Have one more question, unhold when you think it is not an issue:

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2025
- PULL_BASE_REF=${_PULL_BASE_REF}
- REGISTRY_NAME=gcr.io/${_STAGING_PROJECT}
- HOME=/root
- GIT_TAG=${_GIT_TAG}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the space for the following 4 lines be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's the yaml linter fixing some spaces

@upodroid
Copy link
Member Author

Can we get this merged, a new tag cut and images promoted please?

Do you just want a new version instead of cherry-pick to previous branches?

A new version is fine.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit bf08858 into kubernetes-sigs:master Oct 28, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants