Skip to content

Conversation

@kishen-v
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR makes usage of different cloud APIs to achieve the same as the existing flow. The changes made improve the time taken to handle the cloud calls for the Create+Publish calls has now reduced to ~33s from the existing ~40 seconds (Over repeated tests).

And with the delete flow, the time associated with the Unpublish stage is about ~15 seconds with the changes vs ~22 seconds earlier.

A few changes are also made to capture the information related to the disks itself:
Earlier:

Source:
    Type:              CSI (a Container Storage Interface (CSI) volume source)
    Driver:            powervs.csi.ibm.com
    FSType:            xfs
    VolumeHandle:      xxx-x-xxx-xxx-xxx
    ReadOnly:          false
    VolumeAttributes:      storage.kubernetes.io/csiProvisionerIdentity=x-x-x-x-x-powervs.csi.ibm.com
Events:                <none>

With the changes:

Source:
    Type:              CSI (a Container Storage Interface (CSI) volume source)
    Driver:            powervs.csi.ibm.com
    FSType:            xfs
    VolumeHandle:     xxx-x-xxx-xxx-xxx
    ReadOnly:          false
    VolumeAttributes:      diskType=tier3
                           name=pvc-xxxx-xxxx-xxx-xxxx
                           shareable=false
                           storage.kubernetes.io/csiProvisionerIdentity=x-x-x-x-x-powervs.csi.ibm.com
                           wwn=xxxxxxxxxxxxxxxxxxx

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

Capture disk related information such as tier, wwn, etc. under `VolumeAttributes`.
Clean up Publish and Unpublish flow.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kishen-v
Once this PR has been reviewed and has the lgtm label, please assign yussufsh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 27, 2025
@kishen-v kishen-v changed the title Improve time taken to create/delete volumes [WIP]Improve time taken to create/delete volumes Oct 27, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2025
@kishen-v kishen-v force-pushed the cleanup-publish-unpublish branch from 2995151 to cf2a482 Compare October 28, 2025 08:23
@kishen-v kishen-v changed the title [WIP]Improve time taken to create/delete volumes Improve time taken to create/delete volumes Oct 28, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2025
@kishen-v kishen-v force-pushed the cleanup-publish-unpublish branch from cf2a482 to 05ab117 Compare October 28, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants