Skip to content

Conversation

@booxter
Copy link

@booxter booxter commented Oct 15, 2025

On add, a new node of the chosen role is created and joins the k8s
cluster.

On delete, the node is removed from etcd cluster, drained and gracefully
removed from k8s cluster.

Note: only docker is implemented. Other backends can be added later as
needed.

Signed-off-by: Ihar Hrachyshka ihrachyshka@nvidia.com
Assisted-By: Claude Code; claude-sonnet-4-20250514


RFE: #4034

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 15, 2025
@k8s-ci-robot k8s-ci-robot requested a review from aojea October 15, 2025 01:07
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: booxter
Once this PR has been reviewed and has the lgtm label, please assign aojea for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @booxter!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the area/provider/docker Issues or PRs related to docker label Oct 15, 2025
@k8s-ci-robot k8s-ci-robot added area/provider/nerdctl Issues or PRs related to nerdctl needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 15, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @booxter. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/provider/podman Issues or PRs related to podman size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 15, 2025
On add, a new node of the chosen role is created and joins the k8s
cluster.

On delete, the node is removed from etcd cluster, drained and gracefully
removed from k8s cluster.

Note: only docker is implemented. Other backends can be added later as
needed.

Signed-off-by: Ihar Hrachyshka <ihrachyshka@nvidia.com>
Assisted-By: Claude Code; claude-sonnet-4-20250514
@booxter booxter marked this pull request as ready for review October 15, 2025 02:09
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2025
@BenTheElder
Copy link
Member

Thanks for the PR. We generally ask that features be discussed in an issue first as per our contributing guide:

https://kind.sigs.k8s.io/docs/contributing/getting-started/#4-reaching-out

@aojea
Copy link
Contributor

aojea commented Oct 15, 2025

yeah, also explain better what is the use case for adding this behavior

@booxter
Copy link
Author

booxter commented Oct 15, 2025

Thanks folks. Let me put it in draft to make it clear it's not ready for review. Will follow up with a RFE issue later.

@booxter booxter marked this pull request as draft October 15, 2025 12:45
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2025
@booxter
Copy link
Author

booxter commented Oct 18, 2025

This won't be allowed in kind. We will discuss in RFE ways forward; then close RFE too once we know where the code better belongs.

@booxter booxter closed this Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/provider/docker Issues or PRs related to docker area/provider/nerdctl Issues or PRs related to nerdctl area/provider/podman Issues or PRs related to podman cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants