-
Couldn't load subscription status.
- Fork 1.7k
feat: Add {add,delete} node commands #4031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: booxter The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @booxter! |
|
Hi @booxter. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
a623239 to
8ac6092
Compare
On add, a new node of the chosen role is created and joins the k8s cluster. On delete, the node is removed from etcd cluster, drained and gracefully removed from k8s cluster. Note: only docker is implemented. Other backends can be added later as needed. Signed-off-by: Ihar Hrachyshka <ihrachyshka@nvidia.com> Assisted-By: Claude Code; claude-sonnet-4-20250514
8ac6092 to
0eb0e66
Compare
|
Thanks for the PR. We generally ask that features be discussed in an issue first as per our contributing guide: https://kind.sigs.k8s.io/docs/contributing/getting-started/#4-reaching-out |
|
yeah, also explain better what is the use case for adding this behavior |
|
Thanks folks. Let me put it in draft to make it clear it's not ready for review. Will follow up with a RFE issue later. |
|
This won't be allowed in kind. We will discuss in RFE ways forward; then close RFE too once we know where the code better belongs. |
On add, a new node of the chosen role is created and joins the k8s
cluster.
On delete, the node is removed from etcd cluster, drained and gracefully
removed from k8s cluster.
Note: only docker is implemented. Other backends can be added later as
needed.
Signed-off-by: Ihar Hrachyshka ihrachyshka@nvidia.com
Assisted-By: Claude Code; claude-sonnet-4-20250514
RFE: #4034