-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Add price info for N4A machine family #8687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @drjackild. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/release-note-edit |
|
@drjackild thank you for this, is there any official documentation that can aid reviewers here? code lgtm, just would like to make sure that I can add some value w/ respect to validating that the numbers are correct |
|
/ok-to-test |
jackfrancis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@jackfrancis thank you for a super-quick review! Unfortunately no, there is no public source of truth for those numbers yet. Let's wait for @x13n or @towca to confirm and unhold this. |
9193d63 to
f94f37c
Compare
jackfrancis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: drjackild, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Verified the prices, everything seems to match! /unhold |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add price information for N4A machine family