Skip to content

Conversation

@jackfrancis
Copy link
Contributor

@jackfrancis jackfrancis commented Oct 24, 2025

What type of PR is this?

What this PR does / why we need it:

From the docker buildx build documentation:

--provenance string Shorthand for "--attest=type=provenance"

This PR sets --provenance=false for cluster-autoscaler docker image builds to allow better ergonomics for including architecture-specific images (e.g., registry.k8s.io/autoscaling/cluster-autoscaler-amd64:v1.34.1) into a cross-arch manifest (e.g., registry.k8s.io/autoscaling/cluster-autoscaler:v1.34.1).

Otherwise we will include attestation manifests data in the resultant image build, and run into errors like this one:

docker manifest create gcr.io/k8s-staging-autoscaling/cluster-autoscaler:v1.30.7 \
      gcr.io/k8s-staging-autoscaling/cluster-autoscaler-amd64:v1.30.7 gcr.io/k8s-staging-autoscaling/cluster-autoscaler-arm64:v1.30.7 gcr.io/k8s-staging-autoscaling/cluster-autoscaler-s390x:v1.30.7
gcr.io/k8s-staging-autoscaling/cluster-autoscaler-amd64:v1.30.7 is a manifest list

Credit to @cpuguy83

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Build images without attestation manifests

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area labels Oct 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler and removed do-not-merge/needs-area labels Oct 24, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2025
@jackfrancis
Copy link
Contributor Author

/release-note-edit

Build images without attestation manifests

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 24, 2025
@jackfrancis
Copy link
Contributor Author

/cherry-pick cluster-autoscaler-release-1.34
/cherry-pick cluster-autoscaler-release-1.33
/cherry-pick cluster-autoscaler-release-1.32
/cherry-pick cluster-autoscaler-release-1.31

@k8s-infra-cherrypick-robot

@jackfrancis: once the present PR merges, I will cherry-pick it on top of cluster-autoscaler-release-1.31, cluster-autoscaler-release-1.32, cluster-autoscaler-release-1.33, cluster-autoscaler-release-1.34 in new PRs and assign them to you.

In response to this:

/cherry-pick cluster-autoscaler-release-1.34
/cherry-pick cluster-autoscaler-release-1.33
/cherry-pick cluster-autoscaler-release-1.32
/cherry-pick cluster-autoscaler-release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants