-
Couldn't load subscription status.
- Fork 4.2k
Small e2e test cleanup #8694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Small e2e test cleanup #8694
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianmoisey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| "k8s.io/kubernetes/test/e2e/framework" | ||
| e2edeploy "k8s.io/kubernetes/test/e2e/framework/deployment" | ||
| "k8s.io/utils/pointer" | ||
| "k8s.io/utils/ptr" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have the appetite to update these everywhere so we can remove the k8s.io/utils/pointer package from the dependency graph altogether? (less value doing the same for io/ioutil as that's part of the standard lib, but you could do the same there as well if you're starved for dopamine)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change removes the last one, from what I can tell. Which other k8s.io/utils/pointer references are left?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I would expect vertical-pod-autoscaler/e2e/vendor/modules.txt would have been updated when the final in-code reference is removed
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
While looking at the e2e tests, I thought I'd fix a few minor nits
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: