Skip to content

fix: pin github action to exact SHA#979

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
jsafrane:pin-github-actions-sha
Apr 2, 2026
Merged

fix: pin github action to exact SHA#979
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
jsafrane:pin-github-actions-sha

Conversation

@jsafrane
Copy link
Copy Markdown
Member

Pin GitHub Actions to exact commit SHAs instead of mutable tags.

References to master or other branch names have been pinned to the latest
release version.

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 31, 2026
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 31, 2026
Copy link
Copy Markdown
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2026
@thockin
Copy link
Copy Markdown
Member

thockin commented Mar 31, 2026

Why?

@jsafrane
Copy link
Copy Markdown
Member Author

To prevent someone bad re-tagging say golangci/golangci-lint-action@v9 to something bad, just like it happened to trivy.

@jsafrane
Copy link
Copy Markdown
Member Author

jsafrane commented Apr 1, 2026

found the official policy: https://github.com/kubernetes/community/blob/main/github-management/github-actions-policy.md

@thockin
Copy link
Copy Markdown
Member

thockin commented Apr 2, 2026

Sigh, thanks.

What a terrible mess we've all made.

@thockin
Copy link
Copy Markdown
Member

thockin commented Apr 2, 2026

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, thockin, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2026
@k8s-ci-robot k8s-ci-robot merged commit 7ffab78 into kubernetes:master Apr 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants