add --init-period and --init-timeout flags#980
add --init-period and --init-timeout flags#980knQzx wants to merge 2 commits intokubernetes:masterfrom
Conversation
|
Welcome @knQzx! |
thockin
left a comment
There was a problem hiding this comment.
Thanks. The code looks good, but I'd really like e2e tests to cover these (test_e2e.sh)
| dynamic credentials from an external secrets system). | ||
| See also $GITSYNC_PASSWORD. | ||
|
|
||
| --init-period <duration>, $GITSYNC_INIT_PERIOD |
There was a problem hiding this comment.
please keep this section alphabetical -- these should go earlier
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: knQzx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
thanks for the feedback, fixed - moved flags to alphabetical order, added readme docs, and added e2e tests for both init-period and init-timeout |
summary
--init-periodflag - used for retries until the first successful sync, then switches to normal--period--init-timeoutflag - max time to keep retrying the initial sync before exiting with failuretest plan
chooseWaitTime()andisInitTimedOut()helper functionsgo test ./...go build ./...fixes #959