Skip to content

Promote csi-snapshot-metadata for Kubernetes 1.34 #8702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2025
Merged

Promote csi-snapshot-metadata for Kubernetes 1.34 #8702

merged 1 commit into from
Oct 30, 2025
+1 −0

Conversation

@jsafrane
Copy link
Member

@jsafrane jsafrane commented Oct 27, 2025

Promote CSI sidecar images that we released recently.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 27, 2025
@k8s-ci-robot k8s-ci-robot requested review from humblec and pohly October 27, 2025 11:44
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Oct 27, 2025
@jsafrane
Copy link
Member Author

jsafrane commented Oct 27, 2025

cc @xing-yang @msau42

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 27, 2025
jackfrancis
jackfrancis reviewed Oct 27, 2025
View reviewed changes
registry.k8s.io/images/k8s-staging-sig-storage/images.yaml Outdated
"sha256:160f1906b49914e544a68d96a97eaa71107b600cee883b60ce1ab9c71d02ae63": [ "v0.13.0" ]
"sha256:65d118e955cfa0827d0f727fe161a7469e0e1c6829c347a484130aeb6e45f377": [ "v0.14.0" ]
"sha256:ce054c6fade575e9d4dbd4c3d65b9c5d1b05160aacfb9cf8d8cac51d73f3ccea": [ "v0.15.0" ]
"sha256:d0ed3046b612c2f8341de5705f5da6388bca6189dc2412a0929afb77fff7bbba": [ "v0.15.0" ]
Copy link
Contributor

@jackfrancis jackfrancis Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to change the SHA of an existing immutable image tag?

Copy link
Contributor

@xing-yang xing-yang Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we have a new sha for the same image version.
@jsafrane can you revert this change? If this gets merged, the promotion of other images will fail post checkin.

Copy link
Member Author

@jsafrane jsafrane Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@msau42
Copy link
Member

msau42 commented Oct 29, 2025

you may have to rebase with #8705

@jsafrane
Copy link
Member Author

jsafrane commented Oct 30, 2025

rebased, now it's just the csi-snapshot-metadata image

@jsafrane jsafrane changed the title Promote CSI sidecars for Kubernetes 1.34 Promote csi-snapshot-metadata for Kubernetes 1.34 Oct 30, 2025
@xing-yang
Copy link
Contributor

xing-yang commented Oct 30, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c839081 into kubernetes:main Oct 30, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@humblec humblec Awaiting requested review from humblec

@pohly pohly Awaiting requested review from pohly

2 more reviewers

@xing-yang xing-yang xing-yang left review comments

@jackfrancis jackfrancis jackfrancis left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@xing-yang xing-yang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

5 participants

@jsafrane @msau42 @xing-yang @k8s-ci-robot @jackfrancis