kubeadm: added container runtime version check to preflight #134906

carlory · 2025-10-27T09:52:24Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR is related to:

Fixes kubernetes/kubeadm#3229

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubeadm: added a new preflight check to validate if the container runtime supports the RuntimeConfig gRPC method. If the container runtime does not support the RuntimeConfig gRPC method, a warning is printed.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://kep.k8s.io/4033

Signed-off-by: carlory <baofa.fan@daocloud.io>

k8s-ci-robot · 2025-10-27T09:52:27Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

k8s-ci-robot · 2025-10-27T09:52:33Z

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-10-27T09:52:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~cmd/kubeadm/OWNERS~~ [carlory]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

carlory · 2025-10-27T09:54:01Z

/hold

pacoxu · 2025-10-29T06:51:25Z

kubeadm: added a new preflight check to validate if the container runtime supports the RuntimeConfig gRPC method. If the container runtime does not support the RuntimeConfig gRPC method, a warning is printed.

https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/cri-api/README.md#v128

kubelet: get cgroup driver config from CRI kubelet: get cgroup driver config from CRI #118770

Checking RuntimeConfig is a little trick here. However, containerd version is not in cri info. I think this would be OK.

carlory · 2025-10-29T07:39:36Z

This PR assumes that the container runtime is running on the node when we do init, join or upgrade operations. I'm unsure whether it is correct? If yes, I will add the same check for init/join operations.

neolit123

SGTM, added a few minor comments.

neolit123 · 2025-10-29T10:09:45Z

cmd/kubeadm/app/preflight/checks.go

+
+	kubeletVersion, err := GetKubeletVersion(crc.exec)
+	if err != nil {
+		return nil, []error{errors.Wrap(err, "couldn't get kubelet version")}


Suggested change

return nil, []error{errors.Wrap(err, "couldn't get kubelet version")}

return nil, []error{errors.Wrap(err, "could not get kubelet version")}

neolit123 · 2025-10-29T10:10:14Z

cmd/kubeadm/app/preflight/checks.go

+
+	ok, err := crc.runtime.IsRuntimeConfigImplemented()
+	if err != nil {
+		return nil, []error{errors.Wrap(err, "couldn't check if runtime config is available")}


Suggested change

return nil, []error{errors.Wrap(err, "couldn't check if runtime config is available")}

return nil, []error{errors.Wrap(err, "could not check if the runtime config is available")}

neolit123 · 2025-10-29T10:10:59Z

cmd/kubeadm/app/preflight/checks.go

+		return nil, []error{errors.Wrap(err, "couldn't check if runtime config is available")}
+	}
+	if !ok {
+		if kubeletVersion.GreaterThan(versionutil.MustParseSemantic("v1.35.0")) {


Suggested change

if kubeletVersion.GreaterThan(versionutil.MustParseSemantic("v1.35.0")) {

if kubeletVersion.GreaterThan(versionutil.MustParseSemantic("v1.35.0-0")) {

to handle 1.35 pre-releases?

neolit123 · 2025-10-29T10:12:50Z

cmd/kubeadm/app/util/runtime/runtime.go

 	"time"

+	"google.golang.org/grpc/codes"
+	"google.golang.org/grpc/status"


Suggested change

"google.golang.org/grpc/status"

"google.golang.org/grpc/status"

separate import group for non-k8s imports.

neolit123 · 2025-10-29T10:18:25Z

cmd/kubeadm/app/preflight/checks.go

+	}
+	if !ok {
+		if kubeletVersion.GreaterThan(versionutil.MustParseSemantic("v1.35.0")) {
+			err := errors.New("CRI implementation should be updated to support RuntimeConfig. " +


Suggested change

err := errors.New("CRI implementation should be updated to support RuntimeConfig. " +

err := errors.New("You must update your container runtime to a version that supports the CRI method RuntimeConfig. " +

we need to make it clear that that the user must update their container runtime.

neolit123 · 2025-10-29T10:18:32Z

cmd/kubeadm/app/preflight/checks.go

+				"For more information, see https://git.k8s.io/enhancements/keps/sig-node/4033-group-driver-detection-over-cri")
+			errorList = append(errorList, err)
+		} else {
+			warning := errors.New("CRI implementation should be updated to support RuntimeConfig. " +


neolit123 · 2025-10-29T10:19:55Z

This PR assumes that the container runtime is running on the node when we do init, join or upgrade operations. I'm unsure whether it is correct? If yes, I will add the same check for init/join operations.

yes, think we assume the container runtime is running before these commands are executed.

neolit123 · 2025-10-29T10:21:14Z

kubeadm: added a new preflight check to validate if the container runtime supports the RuntimeConfig gRPC method. If the container runtime does not support the RuntimeConfig gRPC method, a warning is printed.

best to also mention what actions the users need to take for what releases and what this config used for.
if they don't take an action we return error.

kubeadm: added container runtime version check to preflight

e57c707

Signed-off-by: carlory <baofa.fan@daocloud.io>

k8s-ci-robot requested review from HirazawaUi and SataQiu October 27, 2025 09:52

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2025

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2025

carlory mentioned this pull request Oct 27, 2025

Add a new preflight check to the deprecation for the containerd 1.y and kubernetes 1.34+ integration. kubernetes/kubeadm#3229

Open

neolit123 reviewed Oct 29, 2025

View reviewed changes

	return nil, []error{errors.Wrap(err, "couldn't get kubelet version")}
	return nil, []error{errors.Wrap(err, "could not get kubelet version")}

	if kubeletVersion.GreaterThan(versionutil.MustParseSemantic("v1.35.0")) {
	if kubeletVersion.GreaterThan(versionutil.MustParseSemantic("v1.35.0-0")) {

	"google.golang.org/grpc/status"
	"google.golang.org/grpc/status"

	err := errors.New("CRI implementation should be updated to support RuntimeConfig. " +
	err := errors.New("You must update your container runtime to a version that supports the CRI method RuntimeConfig. " +

Uh oh!

kubeadm: added container runtime version check to preflight #134906

Are you sure you want to change the base?

kubeadm: added container runtime version check to preflight #134906

Uh oh!

Conversation

carlory commented Oct 27, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Oct 27, 2025

Uh oh!

k8s-ci-robot commented Oct 27, 2025

Uh oh!

k8s-ci-robot commented Oct 27, 2025

Uh oh!

carlory commented Oct 27, 2025

Uh oh!

pacoxu commented Oct 29, 2025

Uh oh!

carlory commented Oct 29, 2025

Uh oh!

neolit123 left a comment

Choose a reason for hiding this comment

Uh oh!

neolit123 Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

neolit123 Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

neolit123 Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

neolit123 Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

neolit123 Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

neolit123 Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

neolit123 commented Oct 29, 2025

Uh oh!

neolit123 commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants