-
Notifications
You must be signed in to change notification settings - Fork 2.8k
rewrite retest robot comment #35828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite retest robot comment #35828
Conversation
1. The Kubernetes project should not have merge-blocking tests that are too flaky to consistently pass, we've worked hard to eliminate these, and if they come up again it should not be treated as normal 2. The text here is way too long, we should focus on the most essentail details. The contributor does not need to know the search query and we're not even including all of it. 3. Prioritize encouraging helping fix test flakes early in the message instead of ~at the end. 4. The full test history link is already included in test failure comments.
pohly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
In case you want others to chime in.
config/jobs/kubernetes/sig-k8s-infra/trusted/sig-contribex-k8s-triage-robot.yaml
Show resolved
Hide resolved
cblecker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion, otherwise lgtm
config/jobs/kubernetes/sig-k8s-infra/trusted/sig-contribex-triage-robot-retester.yaml
Outdated
Show resolved
Hide resolved
887a1b6 to
cd350a5
Compare
cd350a5 to
8e10e2d
Compare
cblecker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave for @Priyankasaggu11929 // @MadhavJivrajani to give the final thumbs up, but this looks great to me!
|
/lgtm Thanks @BenTheElder and @cblecker! |
|
/assign @upodroid |
upodroid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, cblecker, pohly, Priyankasaggu11929, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
@BenTheElder: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The Kubernetes project should not have merge-blocking tests that are too flaky to consistently pass, we've worked hard to eliminate these, and if they come up again it should not be treated as normal
The text here is way too long, we should focus on the most essentail details. The contributor does not need to know the search query and we're not even including all of it.
Prioritize encouraging helping fix test flakes early in the message instead of ~at the end.
The full test history link is already included in test failure comments.
follow-up to #35169 (comment)
cc @kubernetes/sig-testing-leads @kubernetes/sig-contributor-experience-leads