Skip to content

Conversation

@BenTheElder
Copy link
Member

  1. The Kubernetes project should not have merge-blocking tests that are too flaky to consistently pass, we've worked hard to eliminate these, and if they come up again it should not be treated as normal

  2. The text here is way too long, we should focus on the most essentail details. The contributor does not need to know the search query and we're not even including all of it.

  3. Prioritize encouraging helping fix test flakes early in the message instead of ~at the end.

  4. The full test history link is already included in test failure comments.

follow-up to #35169 (comment)

cc @kubernetes/sig-testing-leads @kubernetes/sig-contributor-experience-leads

1. The Kubernetes project should not have merge-blocking tests that are too flaky to consistently pass, we've worked hard to eliminate these, and if they come up again it should not be treated as normal

2. The text here is way too long, we should focus on the most essentail details. The contributor does not need to know the search query and we're not even including all of it.

3. Prioritize encouraging helping fix test flakes early in the message instead of ~at the end.

4. The full test history link is already included in test failure comments.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 31, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Oct 31, 2025
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

In case you want others to chime in.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2025
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise lgtm

Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave for @Priyankasaggu11929 // @MadhavJivrajani to give the final thumbs up, but this looks great to me!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2025
@Priyankasaggu11929
Copy link
Member

/lgtm
/approve

Thanks @BenTheElder and @cblecker!

@BenTheElder
Copy link
Member Author

/assign @upodroid

Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker, pohly, Priyankasaggu11929, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2025
@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit a255ac2 into kubernetes:master Nov 5, 2025
6 checks passed
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-contribex-k8s-triage-robot.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-contribex-k8s-triage-robot.yaml
  • key sig-contribex-triage-robot-retester.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-contribex-triage-robot-retester.yaml

In response to this:

  1. The Kubernetes project should not have merge-blocking tests that are too flaky to consistently pass, we've worked hard to eliminate these, and if they come up again it should not be treated as normal

  2. The text here is way too long, we should focus on the most essentail details. The contributor does not need to know the search query and we're not even including all of it.

  3. Prioritize encouraging helping fix test flakes early in the message instead of ~at the end.

  4. The full test history link is already included in test failure comments.

follow-up to #35169 (comment)

cc @kubernetes/sig-testing-leads @kubernetes/sig-contributor-experience-leads

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants