- 
                Notifications
    
You must be signed in to change notification settings  - Fork 148
 
WIP: metric guide for ks #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            xyz-li
  wants to merge
  1
  commit into
  kubesphere:master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
xyz-li:master
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from all commits
      Commits
    
    
  File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
        
          
          
            61 changes: 61 additions & 0 deletions
          
          61 
        
  sig-observability/concepts-and-designs/how-to-add-new-metric-to-kubesphere.md
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # Why we need to add metrics to kubesphere | ||
| 
     | 
||
| Metrics can provide insight into the behavior and health of our system. They represent the raw material used by monitoring system to build a holistic view of kubesphere, automate responses to changes, and alert human beings when required. | ||
| 
     | 
||
| # How to add new metric | ||
| 
     | 
||
| * 1. [Define the metric](#Define) | ||
| * 2. [Register the metric](#Register) | ||
| * 3. [Export the metric](#Export) | ||
| 
     | 
||
| 
     | 
||
| ## 1. <a name='Define'></a>Define the metric | ||
| Define the metric in the file `metric.go` of you package or somewhere else. | ||
| 
     | 
||
| ```go | ||
| package application | ||
| 
     | 
||
| import ( | ||
| compbasemetrics "k8s.io/component-base/metrics" | ||
| "kubesphere.io/kubesphere/pkg/utils/metrics" | ||
| ) | ||
| 
     | 
||
| var ( | ||
| // add a counter metric | ||
| appTemplateCreationCounter = compbasemetrics.NewCounterVec( | ||
| &compbasemetrics.CounterOpts{ | ||
| Name: "application_template_creation", // metric name | ||
| Help: "Counter of application template creation broken out for each workspace, name and create state", // metric help info | ||
| StabilityLevel: compbasemetrics.ALPHA, //represents the API guarantees for a given defined metric | ||
| }, | ||
| //we want to export the namespace, name and current state of the appTemplate | ||
| []string{"workspace", "name", "state"}, // the labels of the metric | ||
| ) | ||
| ) | ||
| 
     | 
||
| ``` | ||
| 
     | 
||
| ## 2. <a name='Register'></a>Register the metric | ||
| ```go | ||
| package application | ||
| import ( | ||
| "kubesphere.io/kubesphere/pkg/utils/metrics" | ||
| ) | ||
| 
     | 
||
| func init(){ | ||
| Register() | ||
| } | ||
| 
     | 
||
| func Register() { | ||
| metrics.MustRegister(appTemplateCreationCounter) | ||
| } | ||
| ``` | ||
| 
     | 
||
| ## 3. <a name='Export'></a>Export the metric | ||
| ```go | ||
| package application | ||
| func (c *appTemplateOperator) CreateApp(request *CreateAppRequest) { | ||
| // export app template create metric with label values | ||
| appTemplateCreationCounter.WithLabelValues("workspace", "Name", "failed").Inc() | ||
| } | ||
| ``` | ||
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add :
Description of the metrics scraping port and path
An instrumentation overview link https://prometheus.io/docs/practices/instrumentation/
more naming conversion instructions links like:
https://prometheus.io/docs/practices/naming/
https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels
And also some metrics type instructions links like:
https://prometheus.io/docs/concepts/metric_types/
Intro to the client library
https://prometheus.io/docs/instrumenting/clientlibs/