Skip to content

[release-v1.62] Improve PVC webhook rendering error reporting #3965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kubevirt-bot wants to merge 1 commit into
base: release-v1.62
Choose a base branch
from
Open

[release-v1.62] Improve PVC webhook rendering error reporting #3965

kubevirt-bot wants to merge 1 commit into from

Conversation

@kubevirt-bot
Copy link
Contributor

@kubevirt-bot kubevirt-bot commented Dec 2, 2025

This is an automated cherry-pick of #3958

/assign arnongilboa

Improve PVC webhook rendering error reporting

@arnongilboa
Improve PVC webhook rendering error reporting
ee1ad55 
The issue was that clone PVC webhook rendering flow was silencing failed
Get calls, so the PVC creator had no clue about the root cause error.
The tests failed because due to timing, the VolumeCloneSource was not
found by the webhook cached client. In another case the source PVC
status.capacity[storage] was sometimes not set yet although the PVC is
already Bound. In both cases the webhook failed rendering the PVC size
but did not provide any informative error. The issues are reproduced
(although quite rarely) on rook-ceph-block. The relevant func tests were
also fixed to handle  PVC webhook rendering errors correctly.

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request Dec 2, 2025
Merged
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 2, 2025
@kubevirt-bot
Copy link
Contributor Author

kubevirt-bot commented Dec 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign aglitke for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot
Copy link
Contributor Author

kubevirt-bot commented Dec 2, 2025

@kubevirt-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdi-generate-verify ee1ad55 link true /test pull-cdi-generate-verify
pull-containerized-data-importer-e2e-ceph ee1ad55 link true /test pull-containerized-data-importer-e2e-ceph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akalenyu akalenyu Awaiting requested review from akalenyu

@ShellyKa13 ShellyKa13 Awaiting requested review from ShellyKa13

Assignees

@arnongilboa arnongilboa

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kubevirt-bot @arnongilboa