feat(qrm): topology annotations for allocations#1068
Open
JustinChengLZ wants to merge 17 commits intokubewharf:mainfrom
Open
feat(qrm): topology annotations for allocations#1068JustinChengLZ wants to merge 17 commits intokubewharf:mainfrom
JustinChengLZ wants to merge 17 commits intokubewharf:mainfrom
Conversation
JustinChengLZ
requested review from
luomingmeng,
waynepeking348 and
xu282934741
as code owners
JustinChengLZ
changed the title
JustinChengLZ
force-pushed
the
dev/new_topology_annotations
branch
6 times, most recently
from
fd9d0a6 to
1e3021e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1068 +/- ##
==========================================
+ Coverage 61.47% 61.56% +0.09%
==========================================
Files 783 783
Lines 73167 73658 +491
==========================================
+ Hits 44977 45351 +374
- Misses 23176 23279 +103
- Partials 5014 5028 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JustinChengLZ
force-pushed
the
dev/new_topology_annotations
branch
6 times, most recently
from
e49703a to
2afa828
Compare
JustinChengLZ
force-pushed
the
dev/new_topology_annotations
branch
3 times, most recently
from
d22f30b to
2163af4
Compare
JustinChengLZ
force-pushed
the
dev/new_topology_annotations
branch
from
2163af4 to
8dfdd43
Compare
Add DiscoverMemoryTopology function to calculate normal memory capacity by excluding static hugepages. This enables proper memory accounting in NUMA systems with hugepages configured. The function is now used by the existing Discover method to maintain consistent memory topology information.
Update memory calculations to use NormalMemoryCapacity and NormalMemoryDetails instead of total memory capacity to exclude static hugepages. This provides more accurate resource upper bounds and per-NUMA capacity calculations for memory provisioning and headroom estimation.
Add StaticHugePagesDetails and StaticHugePagesCapacity fields to MemoryTopology to track static hugepages allocation per NUMA node and system-wide. Update test cases and dummy topology generation to include these new fields.
Static huge pages should not be included in the total available memory calculation as they are reserved and cannot be used for dynamic allocation. This change updates the policy to properly account for static huge pages and adds corresponding test cases to verify the behavior.
…lation Add GetMemoryTopology interface to ReadonlyState and implement memory topology support in state management. This enables more precise memory capacity calculations by considering NormalMemoryDetails while excluding hugepages. The change affects multiple state generation functions across the codebase to properly handle memory topology information.
feat(qrm-plugin): support reclaimed cores vpa
JustinChengLZ
force-pushed
the
dev/new_topology_annotations
branch
2 times, most recently
from
befdd42 to
e7a52e4
Compare
JustinChengLZ
force-pushed
the
dev/new_topology_annotations
branch
from
e7a52e4 to
17e2036
Compare
JustinChengLZ
force-pushed
the
dev/new_topology_annotations
branch
from
17e2036 to
3ef3453
Compare
JustinChengLZ
force-pushed
the
dev/new_topology_annotations
branch
from
3ef3453 to
ac0dff6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: