Skip to content

feat(qrm, sysadvisor): Periodically (every 300s) clean up excessive (>2000) dying mem cgroups#1069

Open
Zera-Algorithm wants to merge 6 commits intokubewharf:mainfrom
Zera-Algorithm:main
Open

feat(qrm, sysadvisor): Periodically (every 300s) clean up excessive (>2000) dying mem cgroups#1069
Zera-Algorithm wants to merge 6 commits intokubewharf:mainfrom
Zera-Algorithm:main

Conversation

@Zera-Algorithm
Copy link

What type of PR is this?

feat(qrm, sysadvisor): Periodically (every 300s) clean up excessive (>2000) dying mem cgroups.

BREAKING CHANGES:

  1. Add a scheduled task in SysAdvisor to trigger dying memcg cleanup every 300s.
  2. Add a new task in the QRM plugin to trigger dying memcg cleanup via memory reclamation using memory.reclaim.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 8.13008% with 113 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.74%. Comparing base (9d6f0ff) to head (4224705).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/cgroup/manager/cgroup.go 0.00% 62 Missing ⚠️
...ins/memory/dynamicpolicy/policy_advisor_handler.go 0.00% 32 Missing ⚠️
...saware/resource/memory/plugin/memory_offloading.go 29.62% 19 Missing ⚠️

❌ Your patch check has failed because the patch coverage (8.13%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1069      +/-   ##
==========================================
- Coverage   60.83%   60.74%   -0.10%     
==========================================
  Files         739      739              
  Lines       69769    69890     +121     
==========================================
+ Hits        42443    42453      +10     
- Misses      22567    22679     +112     
+ Partials     4759     4758       -1     
Flag Coverage Δ
unittest 60.74% <8.13%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…>2000) dying mem cgroups.

BREAKING CHANGES:
1. Add a scheduled task in SysAdvisor to trigger dying memcg cleanup every 300s.
2. Add a new task in the QRM plugin to trigger dying memcg cleanup via memory reclamation using memory.reclaim.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant