Skip to content

fix(qosaware): remove overload check logic to avoid excessive eviction#1081

Merged
luomingmeng merged 1 commit intokubewharf:mainfrom
jinxin32:headroom
Mar 23, 2026
Merged

fix(qosaware): remove overload check logic to avoid excessive eviction#1081
luomingmeng merged 1 commit intokubewharf:mainfrom
jinxin32:headroom

Conversation

@jinxin32
Copy link
Copy Markdown
Collaborator

@jinxin32 jinxin32 commented Mar 4, 2026

What type of PR is this?

Bug Fixes

What this PR does / why we need it:

This PR removes the overload check logic in calculating headroom. This check will reduce headroom to 0 when overload is detected. However, this will cause excessive eviction, which reduces overall performance.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 60.87%. Comparing base (9d6f0ff) to head (889c8cb).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...n/qosaware/resource/helper/estimation_canonical.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1081      +/-   ##
==========================================
+ Coverage   60.83%   60.87%   +0.03%     
==========================================
  Files         739      739              
  Lines       69769    69743      -26     
==========================================
+ Hits        42443    42453      +10     
+ Misses      22567    22536      -31     
+ Partials     4759     4754       -5     
Flag Coverage Δ
unittest 60.87% <87.50%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cheney-lin
cheney-lin previously approved these changes Mar 9, 2026
@luomingmeng luomingmeng merged commit 89bf7a2 into kubewharf:main Mar 23, 2026
19 checks passed
@jinxin32 jinxin32 deleted the headroom branch March 23, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workflow/need-review review: test succeeded, need to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants