feat(memory): add memory socket binding for dedicated and shared cores pods#1094
Open
luomingmeng wants to merge 2 commits intokubewharf:mainfrom
Open
feat(memory): add memory socket binding for dedicated and shared cores pods#1094luomingmeng wants to merge 2 commits intokubewharf:mainfrom
luomingmeng wants to merge 2 commits intokubewharf:mainfrom
Conversation
90c4221 to
ad4ec1a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1094 +/- ##
==========================================
- Coverage 61.00% 60.89% -0.12%
==========================================
Files 739 739
Lines 69780 69799 +19
==========================================
- Hits 42570 42501 -69
- Misses 22445 22518 +73
- Partials 4765 4780 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…s pods enable memory socket binding to expand memory allocation to the whole socket when enabled for dedicated_cores and shared_cores pods
Add check to skip socket memory binding expansion when pod is marked as numa_exclusive. Add test cases to verify behavior for both dedicated and shared cores pods.
344cbad to
bc03d15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
Enable memory socket binding to expand memory allocation to the whole socket when enabled for dedicated_cores and shared_cores pods.
Which issue(s) this PR fixes:
Special notes for your reviewer: