Skip to content

feat(memory): add memory socket binding for dedicated and shared cores pods#1094

Open
luomingmeng wants to merge 2 commits intokubewharf:mainfrom
luomingmeng:dev/support-numa-binding-pod-memset-bind-socket
Open

feat(memory): add memory socket binding for dedicated and shared cores pods#1094
luomingmeng wants to merge 2 commits intokubewharf:mainfrom
luomingmeng:dev/support-numa-binding-pod-memset-bind-socket

Conversation

@luomingmeng
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

Enable memory socket binding to expand memory allocation to the whole socket when enabled for dedicated_cores and shared_cores pods.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng force-pushed the dev/support-numa-binding-pod-memset-bind-socket branch from 90c4221 to ad4ec1a Compare March 11, 2026 05:34
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.89%. Comparing base (144a9e2) to head (bc03d15).
⚠️ Report is 153 commits behind head on main.

Files with missing lines Patch % Lines
...md/katalyst-agent/app/options/qrm/memory_plugin.go 50.00% 2 Missing ⚠️
...memory/dynamicpolicy/policy_allocation_handlers.go 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1094      +/-   ##
==========================================
- Coverage   61.00%   60.89%   -0.12%     
==========================================
  Files         739      739              
  Lines       69780    69799      +19     
==========================================
- Hits        42570    42501      -69     
- Misses      22445    22518      +73     
- Partials     4765     4780      +15     
Flag Coverage Δ
unittest 60.89% <89.28%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…s pods

enable memory socket binding to expand memory allocation to the whole socket when enabled for dedicated_cores and shared_cores pods
Add check to skip socket memory binding expansion when pod is marked as numa_exclusive.
Add test cases to verify behavior for both dedicated and shared cores pods.
@luomingmeng luomingmeng force-pushed the dev/support-numa-binding-pod-memset-bind-socket branch from 344cbad to bc03d15 Compare March 19, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant