feat(maintainer-label): display maintainer label as author #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvanderlaan
pushed a commit
to bvanderlaan/docker-registry-frontend
that referenced
this pull request
Jun 9, 2018
Docker has deprecated the stanza in favour of the label (https://docs.docker.com/v17.03/engine/reference/builder/) This change set updates the UI to first look for the maintainer label when showing the author of the image. If the Image does not have a mainatiner label it will fall back tot he maintainer stanza. This was pulled from PR kwk#174 by 0xC4N1 in the parent repo
bvanderlaan
pushed a commit
to bvanderlaan/docker-registry-frontend
that referenced
this pull request
Jun 9, 2018
Docker has deprecated the stanza in favour of the label (https://docs.docker.com/v17.03/engine/reference/builder/) This change set updates the UI to first look for the maintainer label when showing the author of the image. If the Image does not have a mainatiner label it will fall back tot he maintainer stanza. This was pulled from PR kwk#174 by 0xC4N1 in the parent repo
bvanderlaan
pushed a commit
to bvanderlaan/docker-registry-frontend
that referenced
this pull request
Jun 9, 2018
Docker has deprecated the stanza in favour of the label (https://docs.docker.com/v17.03/engine/reference/builder/) This change set updates the UI to first look for the maintainer label when showing the author of the image. If the Image does not have a mainatiner label it will fall back tot he maintainer stanza. This was pulled from PR kwk#174 by 0xC4N1 in the parent repo
gabstv
approved these changes
Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker considers the
MAINTAINERinstruction as deprecated and suggests to move the maintainer information to the labels.This pull request implements support for both variants and prefers the maintainer label if available.