fix/refactor(qt): address CodeRabbit review feedback on client_feeds#1

Closed

thepastaclaw wants to merge 18 commits intokwvg:client_feedsfrom

thepastaclaw:fix/client-feeds-review-feedback

Commits on Feb 17, 2026

refactor: s/ProposalList/Proposals/g
kwvg
committed
move-only: src/qt/governancelist.{cpp,h} -> src/qt/proposallist.{cpp,h}
kwvg
committed
refactor(qt): pull out proposal data sourcing to `ProposalFeed`
kwvg
committed
feat(qt): introduce framework for sourcing and applying data
kwvg
committed
qt: register proposal information as a feed, replace per-wallet thread
kwvg
committed
refactor(qt): pull out proposal data sourcing to `MasternodeFeed`
kwvg
committed
qt: register masternode information as a feed, replace per-wallet thread
kwvg
committed
lint: update circular dependencies allowlist
kwvg
committed
move-only: move definitions to clientfeeds.{cpp,h} to deal with circulars
kwvg
committed
fix(qt): use std::atomic for m_syncing to prevent data race

thepastaclaw
and
claude
committed
fix(qt): explicitly delete m_worker in ClientFeeds::stop()

thepastaclaw
and
claude
committed
fix(qt): refresh masternode feed on block height updates

thepastaclaw
and
claude
committed
refactor(qt): update stale doc comment on ProposalList

thepastaclaw
and
claude
committed
refactor(qt): fix variable shadowing in MasternodeFeed::fetch()

thepastaclaw
and
claude
committed
refactor(qt): remove unused QThread forward declaration from masternodelist

thepastaclaw
and
claude
committed
refactor(qt): remove unused CDeterministicMNList forward declaration

thepastaclaw
and
claude
committed
refactor(qt): consolidate QDialog::accepted connections into one lambda

thepastaclaw
and
claude
committed
refactor(qt): consolidate duplicate type aliases for Proposals and MasternodeEntryList

thepastaclaw
and
claude
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix/refactor(qt): address CodeRabbit review feedback on client_feeds#1

fix/refactor(qt): address CodeRabbit review feedback on client_feeds#1
thepastaclaw wants to merge 18 commits intokwvg:client_feedsfrom
thepastaclaw:fix/client-feeds-review-feedback

Commits on Feb 17, 2026

refactor: s/ProposalList/Proposals/g

move-only: src/qt/governancelist.{cpp,h} -> src/qt/proposallist.{cpp,h}

refactor(qt): pull out proposal data sourcing to `ProposalFeed`

feat(qt): introduce framework for sourcing and applying data

qt: register proposal information as a feed, replace per-wallet thread

refactor(qt): pull out proposal data sourcing to `MasternodeFeed`

qt: register masternode information as a feed, replace per-wallet thread

lint: update circular dependencies allowlist

move-only: move definitions to clientfeeds.{cpp,h} to deal with circulars

fix(qt): use std::atomic for m_syncing to prevent data race

fix(qt): explicitly delete m_worker in ClientFeeds::stop()

fix(qt): refresh masternode feed on block height updates

refactor(qt): update stale doc comment on ProposalList

refactor(qt): fix variable shadowing in MasternodeFeed::fetch()

refactor(qt): remove unused QThread forward declaration from masternodelist

refactor(qt): remove unused CDeterministicMNList forward declaration

refactor(qt): consolidate QDialog::accepted connections into one lambda

refactor(qt): consolidate duplicate type aliases for Proposals and MasternodeEntryList