-
Notifications
You must be signed in to change notification settings - Fork 49
M141 public #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HinTak
wants to merge
47
commits into
kyamagu:main
Choose a base branch
from
HinTak:m141-public
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
M141 public #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….0-457-ga46d5732d9)
….40.0-787-g0f94c19331)
… freetype compatibility." This reverts commit bfccc58.
….40.0-795-gcbc694239b)
….40.0-1240-gb57e04d1c7)
…, and removed.
It was deprecated in m139, and gone in m140.
Milestone 139
-------------
* `SkFontMgr_New_FontConfig` with 1 parameter has been deprecated and will be removed in a future
release. Clients will need to call the other version providing an SkFontScanner (e.g.
`SkFontScanner_Make_FreeType()`)
Conflicts:
src/skia/Font.cpp
…favor of the `SkRecorder*` version.
Milestone 140
-------------
* `SkImage::isValid(GrRecordingContext*)` has been deprecated in favor of the `SkRecorder*` version.
To migrate do something like `image->isValid(ctx->asRecorder())`.
`SkImage::makeSubset(GrDirectContext*, ...)` has been deprecated in favor of the `SkRecorder*`
version. To migrate, do something like `image->makeSubset(ctx->asRecorder, ..., {})`
`SkImage::makeColorSpace(GrDirectContext*, ...)` has been deprecated in favor of the `SkRecorder*`
version. To migrate, do something like `image->makeColorSpace(ctx->asRecorder, ..., {})`
`SkImage::makeColorTypeAndColorSpace(GrDirectContext*, ...)` has been deprecated in favor of the
`SkRecorder*` version. To migrate, do something like
`image->makeColorTypeAndColorSpace(ctx->asRecorder, ..., {})`
In the case you are working with CPU-backed images, `skcpu::Recorder::TODO()` should work until
a `skcpu::Context` and `skcpu::Recorder` can be used properly.
…atrix.inverse()
m139:
bool setPolyToPoly(const SkPoint src[], const SkPoint dst[], int count);
m140:
bool setPolyToPoly(SkSpan<const SkPoint> src, SkSpan<const SkPoint> dst);
Before m140, only (deprecated):
[[nodiscard]] bool invert(SkMatrix* inverse) const;
Added in m140:
std::optional<SkMatrix> invert() const;
Old:
bool getSegment(SkScalar startD, SkScalar stopD, SkPath* dst, bool startWithMoveTo);
Newly added:
bool getSegment(SkScalar startD, SkScalar stopD, SkPathBuilder* dst, bool startWithMoveTo);
Old:
bool transform(const SkMatrix& matrix, SkRRect* dst) const;
Newly added:
std::optional<SkRRect> transform(const SkMatrix& matrix) const;
Old:
bool getBoundaryPath(SkPath* path) const;
Newly added:
SkPath getBoundaryPath() const;
was:
bool applyToPath(SkPath* dst, const SkPath& src) const;
m140:
bool applyToPath(SkPathBuilder* dst, const SkPath& src) const;
This reverts commit cd8af0c. Should not be needed in m140.
…0.0-1244-g1fdbea293a)
….40.0-1579-g8843f919a1)
…ck to 2.x Cannot reproduce segfault locally. To investigate. Revert "pybind11 3.0.1 is out; remove limitation not to use 3.0.0" This reverts commit ac7b85a.
…n CI. Back to 2.x" This reverts commit c0d859d.
This is to see why the pybind11 3.0.1 build segfaults at the end of pytest. https://stackoverflow.com/questions/58858429/how-to-run-a-github-actions-step-even-if-the-previous-step-fails-while-still-f
…0.0-1581-g5eefbe51d1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.