M142 public #353
Open
M142 public #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….0-457-ga46d5732d9)
….40.0-787-g0f94c19331)
… freetype compatibility." This reverts commit bfccc58.
….40.0-795-gcbc694239b)
….40.0-1240-gb57e04d1c7)
…, and removed.
It was deprecated in m139, and gone in m140.
Milestone 139
-------------
* `SkFontMgr_New_FontConfig` with 1 parameter has been deprecated and will be removed in a future
release. Clients will need to call the other version providing an SkFontScanner (e.g.
`SkFontScanner_Make_FreeType()`)
Conflicts:
src/skia/Font.cpp
…favor of the `SkRecorder*` version.
Milestone 140
-------------
* `SkImage::isValid(GrRecordingContext*)` has been deprecated in favor of the `SkRecorder*` version.
To migrate do something like `image->isValid(ctx->asRecorder())`.
`SkImage::makeSubset(GrDirectContext*, ...)` has been deprecated in favor of the `SkRecorder*`
version. To migrate, do something like `image->makeSubset(ctx->asRecorder, ..., {})`
`SkImage::makeColorSpace(GrDirectContext*, ...)` has been deprecated in favor of the `SkRecorder*`
version. To migrate, do something like `image->makeColorSpace(ctx->asRecorder, ..., {})`
`SkImage::makeColorTypeAndColorSpace(GrDirectContext*, ...)` has been deprecated in favor of the
`SkRecorder*` version. To migrate, do something like
`image->makeColorTypeAndColorSpace(ctx->asRecorder, ..., {})`
In the case you are working with CPU-backed images, `skcpu::Recorder::TODO()` should work until
a `skcpu::Context` and `skcpu::Recorder` can be used properly.
…atrix.inverse()
m139:
bool setPolyToPoly(const SkPoint src[], const SkPoint dst[], int count);
m140:
bool setPolyToPoly(SkSpan<const SkPoint> src, SkSpan<const SkPoint> dst);
Before m140, only (deprecated):
[[nodiscard]] bool invert(SkMatrix* inverse) const;
Added in m140:
std::optional<SkMatrix> invert() const;
Old:
bool getSegment(SkScalar startD, SkScalar stopD, SkPath* dst, bool startWithMoveTo);
Newly added:
bool getSegment(SkScalar startD, SkScalar stopD, SkPathBuilder* dst, bool startWithMoveTo);
Old:
bool transform(const SkMatrix& matrix, SkRRect* dst) const;
Newly added:
std::optional<SkRRect> transform(const SkMatrix& matrix) const;
Old:
bool getBoundaryPath(SkPath* path) const;
Newly added:
SkPath getBoundaryPath() const;
was:
bool applyToPath(SkPath* dst, const SkPath& src) const;
m140:
bool applyToPath(SkPathBuilder* dst, const SkPath& src) const;
This reverts commit cd8af0c. Should not be needed in m140.
…0.0-1244-g1fdbea293a)
….40.0-1579-g8843f919a1)
…ck to 2.x Cannot reproduce segfault locally. To investigate. Revert "pybind11 3.0.1 is out; remove limitation not to use 3.0.0" This reverts commit ac7b85a.
…n CI. Back to 2.x" This reverts commit c0d859d.
This is to see why the pybind11 3.0.1 build segfaults at the end of pytest. https://stackoverflow.com/questions/58858429/how-to-run-a-github-actions-step-even-if-the-previous-step-fails-while-still-f
…0.0-1581-g5eefbe51d1)
…nvaskit/0.40.0-1581-g5eefbe51d1])
There is a new one:
std::optional<SkPoint> getLastPt() const;
The old one:
// DEPRECATED
bool getLastPt(SkPoint* lastPt) const;
… and SkPathBuilder::detach
commit 8d12d8dc89e647ab1b7e51cd3538e75d1a97be5c
Author: Michael Reed <mike@reedtribe.org>
Date: Tue Sep 16 15:15:53 2025 -0400
Use pathbuilder in path::transform + perspective
- closing the gap on making all paths immutable
- also allows us to transform as we detach
...
Change-Id: I4b6c78909452fffecd3a570399e52a9cccc79419
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1056516
Commit-Queue: Mike Reed <mike@reedtribe.org>
Reviewed-by: Florin Malita <fmalita@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
commit cbb0388767d2b8a5a5c1f5484a68fb0ff201561b
Author: Brian Salomon <briansalomon@gmail.com>
Date: Wed Sep 10 12:34:02 2025 -0400
Move Ganesh-only tool code into tools/ganesh
Graphite-only tooling is separated already into tools/graphite.
Many tools can be built with Ganesh but not Graphite (dm, viewer, ...)
The intermixing of Ganesh and common gpu support code is a significant
contributor to making Graphite but not Ganesh builds difficult.
The files left in the shared code still use macros to selectively
compile Graphite/Ganesh code. Cleaning that up is left as future work.
Change-Id: I33d2fe29368ef3f7ba42b54f62a8d1e0063f5ae3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1051317
Reviewed-by: Thomas Smith <thomsmit@google.com>
Commit-Queue: Brian Salomon <briansalomon@gmail.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kyamagu nothing too exciting, a few new overloads and additional default arguments. This is going to fail CI due to #350 , I think. Still need fo look into that.
I intend to roll python 3.14 into this also, if I can fix #350 .