-
-
Couldn't load subscription status.
- Fork 668
[BUGF-ROUTER][Fixed a small compatibility issue, and added a fallback for models without struct-output] #1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IlumCI
wants to merge
8
commits into
kyegomez:master
Choose a base branch
from
IlumCI:fixed-again
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| if _supports_structured_outputs(self.model): | ||
| lite_llm_kwargs["response_format"] = MultipleHandOffsResponse |
Check failure
Code scanning / Pyre
Incompatible parameter type Error
Incompatible parameter type [6]: In call dict.\_\_setitem\_\_, for 2nd positional argument, expected Union[float, str] but got Type[MultipleHandOffsResponse].
| # Handle JSON parsing with fallback for models without structured outputs | ||
| try: | ||
| boss_response_str = orjson.loads(boss_response_str) | ||
| except (orjson.JSONDecodeError, TypeError): |
Check failure
Code scanning / Pyre
Invalid except clause Error
Invalid except clause [66]: Exception handler type annotation unknown must extend BaseException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fix MultiAgentRouter model compatibility issues with structured outputs and JSON parsing
Issue: #1137
Dependencies: none
Tag maintainer: @kyegomez
Twitter handle: https://x.com/IlumTheProtogen
Changes made:
Why it didn't work last time:
The router was unconditionally setting response_format=MultipleHandOffsResponse for all models, causing BadRequestError on models like gpt-3.5-turbo that don't support json_schema structured outputs. Additionally, model names were using incorrect formats (claude-3-5-sonnet instead of anthropic/claude-3-5-sonnet-20241022) causing provider resolution failures.
Testing:
Results: