Conversation
Owner
Author
colorbox
reviewed
May 11, 2024
| return list1; | ||
| } | ||
| if(list1->val > list2->val) { | ||
| swap(list1, list2); |
colorbox
reviewed
May 11, 2024
| class Solution { | ||
| public: | ||
| ListNode* mergeTwoLists(ListNode* list1, ListNode* list2) { | ||
| ListNode dummy_node(0); |
There was a problem hiding this comment.
dummy_nodeという名前よりも、headのような先頭のニュアンスを持つ名前したほうが直感的に読めてわかりやすくなります。
There was a problem hiding this comment.
私はこの名前はどちらも趣味の範囲かなと思います。このノードは、再帰構造を変形したために形式的に必要となったもので返り値には関わらないものであるという意図を強く出すと dummy と呼びたくなります。
colorbox
reviewed
May 11, 2024
| ListNode* tail = &dummy_node; | ||
|
|
||
| while(list1 && list2) { | ||
| if(list1->val < list2->val) { |
There was a problem hiding this comment.
list1->val < list2->valの関係性をswapを利用して、ループの先頭で維持することで、似たようなことをしているelse節が不要になって読みやすくなりそうです。
また、その際、list1,list2という変数名ではなく、smaller,biggerという変数名にするとそのような関係性であることを変数名から明示できてわかりやすくできます。
|
これはコードに対するコメントではなく、PRの作成に関するコメントですが |
|
インデント直してください。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.