Make Profile flag optional and change default behaviour #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 8, 2021 15:50
…lag optional rather than mandatory. User can pass a single profile or comma seperated list of AWS profiles using -p flag. If -p isnt specified, it will attempt to use any environment which is configured.
rmoles
reviewed
Dec 2, 2021
| while getopts ":p:j" opt; do | ||
| case ${opt} in | ||
| p ) | ||
| USE_PROFILE="true" |
Contributor
There was a problem hiding this comment.
Thanks for adding a description of the script options to the PR.
Could we add something to the echo to describe the fields?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
-pflag optional allowing user to supply one or more profiles to be used to gather inventory.New default behaviour, if
-pis omitted, we'll just use the default AWS CLI behaviour which is to look for env vars such asAWS_SECRET_ACCESS_KEY.Examples:
./lw_aws_inventory.sh- gather inventory for the account defined on the machines env vars./lw_aws_inventory.sh -j- same as above but with JSON output../lw_aws_inventory.sh -p prod- gather inventory for the account with profile prod in~/.aws/credentialsaws-vault exec profile_name -- ./lw_aws_inventory.sh- gather inventory using credentials from aws vault