Skip to content

fix(mesh): Ensure that triangulated_mesh3d never raises exception #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chriswmackey merged 1 commit into from
Sep 25, 2025
Merged

fix(mesh): Ensure that triangulated_mesh3d never raises exception #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ladybug_geometry/geometry2d/mesh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,14 @@ def from_polygon_triangulated(cls, boundary_polygon, hole_polygons=None):
'to use from_polygon_triangulated. Got {}.'.format(type(hole))
_vertices, _faces = Mesh2D._ear_clipping_triangulation(
boundary_polygon, hole_polygons)
_new_mesh = cls(_vertices, _faces)
if len(_faces) != 0:
_new_mesh = cls(_vertices, _faces)
else:
if len(_vertices) >= 3:
_faces = ((0, 1, 2),)
else:
_faces = ((0, 0, 0),)
_new_mesh = cls(_vertices, _faces)

return _new_mesh

Expand Down
31 changes: 31 additions & 0 deletions tests/face3d_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,6 +882,37 @@ def test_triangulated_mesh_edge_case():
assert face_geo.triangulated_mesh3d.area != 0


def test_triangulated_mesh_zero_area():
"""Test triangulation properties of a zero area Face3D."""
verts = (
Point3D(40, 94, 41),
Point3D(46, 99, 40),
Point3D(35, 99, 40),
Point3D(35, 99, 40),
Point3D(46, 99, 40),
Point3D(40, 94, 41),
Point3D(35, 99, 40),
Point3D(35, 99, 40)
)
face = Face3D(verts)
mesh_1 = face.triangulated_mesh3d

assert len(mesh_1.vertices) == 8
assert len(mesh_1.faces) == 1

verts2 = (
Point3D(0, 0, 0),
Point3D(0, 0, 0),
Point3D(0, 0, 0)
)

face2 = Face3D(verts2)
mesh_2 = face2.triangulated_mesh3d

assert len(mesh_2.vertices) == 3
assert len(mesh_2.faces) == 1


def test_check_planar():
"""Test the check_planar method of Face3D."""
pts_1 = (Point3D(0, 0, 2), Point3D(2, 0, 2), Point3D(2, 2, 2), Point3D(0, 2, 2))
Expand Down
Loading