fix(mesh): Ensure that triangulated_mesh3d never raises exception#450
Merged
chriswmackey merged 1 commit intoladybug-tools:masterfrom Sep 25, 2025
Merged
fix(mesh): Ensure that triangulated_mesh3d never raises exception#450chriswmackey merged 1 commit intoladybug-tools:masterfrom
chriswmackey merged 1 commit intoladybug-tools:masterfrom
Conversation
We were getting exceptions raised in the case that a Face3D with zero area was used to make a triangulated_mesh3d. I think the logic follows that, if we allow for the creation of a Face3D with zero area, we should similarly allow it's triangulated Mesh3D to exist with zero area.
chriswmackey
force-pushed
the
master
branch
from
addc2d2 to
f8b2f33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were getting exceptions raised in the case that a Face3D with zero area was used to make a triangulated_mesh3d.
I think the logic follows that, if we allow for the creation of a Face3D with zero area, we should similarly allow it's triangulated Mesh3D to exist with zero area.