Skip to content

fix(commandutil): Ensure output is always encoded to utf-8 #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chriswmackey merged 1 commit into from
Nov 5, 2025
Merged

fix(commandutil): Ensure output is always encoded to utf-8 #643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions ladybug/commandutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# coding=utf-8
"""Utility functions for running the functions of CLI commands outside of the CLI."""
import sys
import os


Expand Down Expand Up @@ -49,11 +50,20 @@ def process_content_to_output(content_str, output_file=None):
dir_name = os.path.dirname(os.path.abspath(output_file))
if not os.path.isdir(dir_name):
os.makedirs(dir_name)
with open(output_file, 'w') as of:
of.write(content_str)
if (sys.version_info < (3, 0)): # we need to manually encode it as UTF-8
with open(output_file, 'w') as of:
of.write(content_str.encode('utf-8'))
else:
with open(output_file, 'w', encoding='utf-8') as of:
of.write(content_str)
else:
if 'stdout' not in str(output_file):
dir_name = os.path.dirname(os.path.abspath(output_file.name))
if not os.path.isdir(dir_name):
os.makedirs(dir_name)
output_file.write(content_str)
if (sys.version_info < (3, 0)): # we need to manually encode it as UTF-8
with open(output_file, 'w') as of:
of.write(content_str.encode('utf-8'))
else:
with open(output_file, 'w', encoding='utf-8') as of:
of.write(content_str)