Skip to content

fix(stat): Ensure that ashrae climate zone is always string #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chriswmackey merged 1 commit into from
Nov 19, 2025
Merged

fix(stat): Ensure that ashrae climate zone is always string #645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ladybug/stat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,9 @@ def _import_data(self):
self._stand_press_at_elev = self._regex_check(
self._press_pattern, self._header[5])
self._ashrae_climate_zone = self._regex_check(
self._ashraecz_pattern, self._body)
self._ashraecz_pattern, self._body, enforce_string=True)
self._koppen_climate_zone = self._regex_check(
self._koppencz_pattern, self._body)
self._koppencz_pattern, self._body, enforce_string=True)

# pull out extreme and seasonal weeks.
self._extreme_hot_week = self._regex_week_parse(self._hotweek_pattern)
Expand Down Expand Up @@ -340,9 +340,11 @@ def _import_data(self):
finally:
statwin.close()

def _regex_check(self, regex_pattern, search_space):
def _regex_check(self, regex_pattern, search_space, enforce_string=False):
matches = regex_pattern.findall(search_space)
if len(matches) > 0:
if enforce_string:
return matches[0]
try:
return float(matches[0])
except ValueError:
Expand Down