-
Notifications
You must be signed in to change notification settings - Fork 100
Add SwiftUI Support #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JakeLin
wants to merge
22
commits into
main
Choose a base branch
from
feature/swift-ui
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca97623 to
b235e0e
Compare
17c8712 to
b6029c4
Compare
37f3a8b to
2707387
Compare
momentsdev
reviewed
May 23, 2021
Collaborator
momentsdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see a few comments
Moments/Moments/Features/Moments-SwiftUI/Views/SwiftUIMomentListItemView.swift
Outdated
Show resolved
Hide resolved
Moments/Moments/Features/Moments-SwiftUI/Views/SwiftUIMomentListItemView.swift
Outdated
Show resolved
Hide resolved
Moments/Moments/Features/Moments-SwiftUI/Views/SwiftUIMomentListItemView.swift
Outdated
Show resolved
Hide resolved
Moments/Moments/Features/Moments-SwiftUI/ObservedObject/MomentsListObservableObject.swift
Outdated
Show resolved
Hide resolved
Moments/Moments/Features/Moments-SwiftUI/Views/SwiftUIMomentsListView.swift
Outdated
Show resolved
Hide resolved
Moments/Moments/Features/Moments-SwiftUI/Views/SwiftUIMomentsListView.swift
Outdated
Show resolved
Hide resolved
Moments/Moments/Features/Moments-SwiftUI/ObservedObject/MomentsListObservableObject.swift
Show resolved
Hide resolved
Moments/Moments/Features/Moments-SwiftUI/Views/SwiftUIUserProfileListItemView.swift
Outdated
Show resolved
Hide resolved
cd3070f to
170f063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use SwiftUI to replace the existing UIKit implementation for the veiw layer.
Details
Description
InternalToggle.isSwiftUIEnabledand let the internal users configure it on the Internal app.Kingfisher/SwiftUIto support async image loading.SceneDelegatewhen the ToggleInternalToggle.isSwiftUIEnabledis on.SwiftUIMomentsListViewfor the Moments List Screen including the user profile and moment.SwiftUIMomentsListItemViewto conditionally return eitherSwiftUIUserProfileListItemVieworSwiftUIMomentListItemViewSwiftUIUserProfileListItemViewfor showing the user profileSwiftUIMomentListItemViewfor showing the momentLikeToggleStylefor a neumorphic design toggle for Like.BlurViewusing UIKit'sUIVisualEffectViewMomentsListObservableObjectto bridge RxSwift and CombineScreengrabs (if applicable)
Quality Analysis
Testing steps:
SwiftUI EnableCrash Appto kill it 💥)Checklist
bundle exec fastlane prepare_pr?