Skip to content

Conversation

@m-messer
Copy link
Member

@m-messer m-messer commented Oct 2, 2025

Enabled support for absolute_tolerance and relative_tolerance with backward compatibility of atol and rtol.
After merging to main and deployment, Lambda Feedback UI can be updated to use relative_tolerance and absolute_tolerance by default instead of rtol and atol.

@m-messer m-messer marked this pull request as ready for review October 2, 2025 10:09
@m-messer m-messer requested a review from peterbjohnson October 2, 2025 10:09
Copy link
Contributor

@peterbjohnson peterbjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and good that there are tests.

We can test on STAGING too before PROD.

Consider requesting a migration in the DB so that legacy content benefits from this change (ask Jarka).

Note that symbolicEqual is an independent function that we need to retire, and that would avoid any discussion of whether we apply maintenance to that function too. Ask me for details. Karl 'finished' work on that but I don't know where we are with completing the obsolescence.

@m-messer
Copy link
Member Author

m-messer commented Oct 2, 2025

Thanks! Currently, we can't test on staging before going to production. Unless I implement my workflow change, which I was going to discuss with you next week. I'm happy to beta test it here.

I'll request a migration, it looks like there are ~32,000 response areas with rtol or atol in

@peterbjohnson
Copy link
Contributor

Ah ok. The fix here isn't urgent. So if STAGING is nearly ready, you could wait and use this as the test case?

@m-messer m-messer assigned m-messer and unassigned peterbjohnson Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants