-
Notifications
You must be signed in to change notification settings - Fork 1
Images Response Area - EduVision #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
timothee-alby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, great new feature!
I've left a couple of suggestions for your consideration.
| this.answer = [] | ||
| } | ||
|
|
||
| customCheck = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this code ever running? I don't see that called anywhere?
I'm curious since this repository doesn't have customCheck defined in ResponseAreaTub.
As it happens, we did recently implement a customCheck function in a more recent version of ResponseAreaTub, and that version is currently running on lambdafeedback.com.
However, our version takes in submissionInput as an arguments and validate that.
Regardless, wince you're manually checking the validity of the answer, I believe this may be redundant as the declared Zod schema takes care of that, doesn't it?
|
|
||
| // --- INPUT COMPONENT --- | ||
|
|
||
| export const ImagesInputComponent: React.FC<BaseResponseAreaProps> = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest defining a custom type here so you can set the actual type of answer and config, which would let you avoid using any. See for example the MultipleChoice component
|
Hey!
Please add the "Images Response Area" component to the page. It’s a new feature that allows users to upload and comment on images, as part of the EduVision project. If you need any changes or further information, feel free to let me know! |
timothee-alby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ErnestTorz , all looking good 💯
We'll have to be looking at this internally and figure out the next step; @m-messer will keep you updated (but that won't be before the holidays break I'm afraid)
Happy holidays to you 🎄
Images Response Area – Detailed Description
This code introduces a highly configurable and reusable "Images Response Area" component for React applications, designed as part of the EduVision project, specifically within the Aero RC subproject. However, due to its modular and general-purpose architecture, it can be easily integrated into other projects or educational platforms requiring image-based user input.
Core Functionality
The Images Response Area enables users to upload, preview, and annotate multiple images as part of their response to a question or task. It is composed of several key parts:
Configuration Options
The component supports a wide range of configuration options, all of which can be set via the wizard or programmatically:
These options are exposed both in the configuration wizard UI and in the underlying schema, allowing for both interactive and programmatic setup.
User Input and Experience
Validation Logic
Validation is enforced at multiple levels:
Generality and Reusability
Although developed within the EduVision project for the Aero RC module, the Images Response Area is written in a highly generic and modular way:
Project and Context
Summary
This Images Response Area provides a robust, user-friendly, and highly configurable solution for collecting image-based responses. Its design emphasizes reusability, strong validation, and ease of integration, making it a valuable addition not only to EduVision but to any project requiring similar functionality.
Note
To use Image Input in sandbox please change the import path in sandbox-component.tsx from './types/Sandbox' to './types/Images'