Skip to content

docs(l1, l2): tweaks and improvements #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Nov 14, 2025
Merged

docs(l1, l2): tweaks and improvements #5097

merged 20 commits into from
Nov 14, 2025

Conversation

@MattLangley
Copy link
Contributor

@MattLangley MattLangley commented Oct 29, 2025 •
edited
Loading

Motivation

Improving doc wording, verbage, links, and content

Description

  • Added inter doc links
  • Updated quickstart steps, the old v7 lighthouse build no longer works so updated to the latest v8.0.0 version

@MattLangley MattLangley changed the title Doc tweaks and improvements docs(l1, l2): tweaks and improvements Oct 29, 2025
@github-actions github-actions bot added L1 Ethereum client L2 Rollup client labels Oct 29, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Benchmark for e2d7565

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 34.7±0.20ms 34.7±0.29ms 0.00%
Trie/cita-trie insert 1k 3.5±0.03ms 3.7±0.19ms +5.71%
Trie/ethrex-trie insert 10k 30.7±0.43ms 31.0±0.77ms +0.98%
Trie/ethrex-trie insert 1k 2.8±0.01ms 2.8±0.01ms 0.00%

@MattLangley MattLangley force-pushed the docs/matt_deeper_doc_pass branch from 9aeb989 to dbcabc8 Compare November 3, 2025 17:37
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Benchmark Results Comparison

No significant difference was registered for any benchmark run.

Detailed Results

Benchmark Results: BubbleSort

Command Mean [s] Min [s] Max [s] Relative
main_revm_BubbleSort 4.765 ± 0.041 4.737 4.875 1.04 ± 0.01
main_levm_BubbleSort 4.620 ± 0.037 4.591 4.712 1.00 ± 0.01
pr_revm_BubbleSort 4.778 ± 0.101 4.724 5.059 1.04 ± 0.02
pr_levm_BubbleSort 4.600 ± 0.016 4.577 4.620 1.00

Benchmark Results: ERC20Approval

Command Mean [s] Min [s] Max [s] Relative
main_revm_ERC20Approval 1.544 ± 0.009 1.532 1.560 1.00
main_levm_ERC20Approval 1.673 ± 0.016 1.653 1.707 1.08 ± 0.01
pr_revm_ERC20Approval 1.545 ± 0.014 1.533 1.582 1.00 ± 0.01
pr_levm_ERC20Approval 1.702 ± 0.057 1.664 1.858 1.10 ± 0.04

Benchmark Results: ERC20Mint

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ERC20Mint 185.8 ± 3.8 183.8 196.5 1.00
main_levm_ERC20Mint 205.5 ± 2.8 204.1 213.2 1.11 ± 0.03
pr_revm_ERC20Mint 186.6 ± 6.4 184.2 204.8 1.00 ± 0.04
pr_levm_ERC20Mint 207.1 ± 1.5 205.7 209.9 1.11 ± 0.02

Benchmark Results: ERC20Transfer

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ERC20Transfer 350.1 ± 1.9 347.9 353.4 1.00 ± 0.01
main_levm_ERC20Transfer 392.1 ± 2.0 390.2 396.7 1.12 ± 0.01
pr_revm_ERC20Transfer 349.9 ± 0.7 348.7 351.1 1.00
pr_levm_ERC20Transfer 395.8 ± 2.0 393.8 399.5 1.13 ± 0.01

Benchmark Results: Factorial

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_Factorial 235.3 ± 0.9 233.7 236.6 1.00
main_levm_Factorial 281.9 ± 1.5 280.6 285.3 1.20 ± 0.01
pr_revm_Factorial 235.9 ± 4.1 233.7 247.4 1.00 ± 0.02
pr_levm_Factorial 282.3 ± 1.1 280.6 284.9 1.20 ± 0.01

Benchmark Results: FactorialRecursive

Command Mean [s] Min [s] Max [s] Relative
main_revm_FactorialRecursive 1.675 ± 0.038 1.616 1.727 1.03 ± 0.07
main_levm_FactorialRecursive 8.563 ± 0.055 8.483 8.639 5.25 ± 0.35
pr_revm_FactorialRecursive 1.630 ± 0.109 1.334 1.708 1.00
pr_levm_FactorialRecursive 8.493 ± 0.107 8.265 8.603 5.21 ± 0.36

Benchmark Results: Fibonacci

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_Fibonacci 216.0 ± 1.9 213.0 220.5 1.00
main_levm_Fibonacci 265.4 ± 5.7 257.4 274.3 1.23 ± 0.03
pr_revm_Fibonacci 216.1 ± 5.0 213.6 230.3 1.00 ± 0.02
pr_levm_Fibonacci 268.5 ± 4.4 264.8 280.1 1.24 ± 0.02

Benchmark Results: FibonacciRecursive

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_FibonacciRecursive 882.8 ± 7.0 874.1 898.0 1.11 ± 0.01
main_levm_FibonacciRecursive 797.0 ± 5.1 791.2 806.4 1.00
pr_revm_FibonacciRecursive 871.3 ± 4.7 862.7 880.0 1.09 ± 0.01
pr_levm_FibonacciRecursive 800.0 ± 18.8 749.0 818.3 1.00 ± 0.02

Benchmark Results: ManyHashes

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ManyHashes 12.6 ± 0.1 12.5 12.7 1.00
main_levm_ManyHashes 14.1 ± 0.1 13.9 14.3 1.12 ± 0.01
pr_revm_ManyHashes 12.8 ± 0.1 12.7 12.9 1.01 ± 0.01
pr_levm_ManyHashes 14.2 ± 0.2 14.1 14.7 1.13 ± 0.02

Benchmark Results: MstoreBench

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_MstoreBench 270.5 ± 2.4 268.9 276.7 1.06 ± 0.01
main_levm_MstoreBench 257.5 ± 2.4 255.1 263.6 1.01 ± 0.01
pr_revm_MstoreBench 297.1 ± 80.8 268.8 526.9 1.16 ± 0.32
pr_levm_MstoreBench 255.6 ± 0.7 254.7 256.6 1.00

Benchmark Results: Push

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_Push 297.4 ± 2.5 295.0 303.8 1.00
main_levm_Push 312.5 ± 1.4 311.1 316.2 1.05 ± 0.01
pr_revm_Push 298.1 ± 3.8 295.6 308.0 1.00 ± 0.02
pr_levm_Push 309.1 ± 1.9 307.2 313.7 1.04 ± 0.01

Benchmark Results: SstoreBench_no_opt

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_SstoreBench_no_opt 220.5 ± 4.3 218.0 232.5 2.59 ± 0.08
main_levm_SstoreBench_no_opt 85.3 ± 2.1 81.5 88.0 1.00 ± 0.03
pr_revm_SstoreBench_no_opt 219.0 ± 0.6 218.0 219.9 2.57 ± 0.06
pr_levm_SstoreBench_no_opt 85.1 ± 1.9 82.8 88.4 1.00

@MattLangley MattLangley marked this pull request as ready for review November 4, 2025 19:17
@MattLangley MattLangley requested a review from a team as a code owner November 4, 2025 19:17
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Nov 4, 2025
@lferrigno lferrigno enabled auto-merge November 7, 2025 17:41
ilitteri
ilitteri reviewed Nov 7, 2025
View reviewed changes
Copy link
Contributor

@ilitteri ilitteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We could take advantage of this PR and address #5242.

@lferrigno lferrigno added this pull request to the merge queue Nov 14, 2025
Merged via the queue into main with commit 126fa80 Nov 14, 2025
42 checks passed
@lferrigno lferrigno deleted the docs/matt_deeper_doc_pass branch November 14, 2025 15:24
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Nov 14, 2025
lakshya-sky pushed a commit to lakshya-sky/ethrex that referenced this pull request Nov 17, 2025
@MattLangley @lferrigno @lakshya-sky
docs(l1, l2): tweaks and improvements (lambdaclass#5097)
1cfa659 
**Motivation**

Improving doc wording, verbage, links, and content

**Description**

- Added inter doc links
- Updated quickstart steps, the old v7 lighthouse build no longer works
so updated to the latest v8.0.0 version

---------

Co-authored-by: Leandro Ferrigno <leanrafa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilitteri ilitteri ilitteri left review comments

@SDartayet SDartayet SDartayet approved these changes

@jrchatruc jrchatruc jrchatruc approved these changes

Assignees

@MattLangley MattLangley

Labels

L1 Ethereum client L2 Rollup client

Projects

ethrex_l1
Status: Done
ethrex_l2
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MattLangley @SDartayet @jrchatruc @ilitteri @lferrigno