fix(l1,l2): inaccurate block execution metrics #5108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the metrics calculations for block processing phases to measure individual phase durations instead of cumulative times.
- Changed
set_merkle_msto measure only the merkleization phase duration (fromexecutedtomerkleized) - Changed
set_store_msto measure only the storage phase duration (frommerkleizedtostored) - Reordered the metric calls to match the chronological order of operations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
edg-l
approved these changes
Oct 30, 2025
azteca1998
approved these changes
Oct 30, 2025
Arkenan
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Disaggregated block execution metrics are off because they count accumulate rather than each process' times.
Given we treat them as parts of a single thing, e.g. later making a pie chart of them, they should be counted as difference from the end of the previous step, like we do in logs.
Description
Fix the subtractions.