-
Notifications
You must be signed in to change notification settings - Fork 119
chore(l1,l2): bump version 6.0.0 #5111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
**Motivation** In a previous PR, DB checkpoints were introduced to ensure old state availability in the current path-based fashion. Every time a batch is sealed, a checkpoint whose state is the state of the latest block of the sealed batch is created to be used in the next batch. The checkpoint is needed in two different steps of the batch commitment: for batch preparation (this is essentially building the batch) and for witness generation. Both steps need a non-modified checkpoint, but they both need to modify the checkpoint to be able to re-execute the batch. As batch preparation occurs before witness generation, we opted to create a one-time checkpoint out of the main checkpoint that can be modified during batch preparation if needed (sometimes the batch was already available in the DB, and there's no need to re-execute anything); then, witness generation modifies the original checkpoint as needed because it is no longer needed. Once the one-time checkpoint fulfills its purpose, it is removed. Currently, if batch preparation fails, the one-time checkpoint is not removed, and after retrying batch preparation, there's another attempt at creating the one-time checkpoint, which ends in an error because the directory already exists. We need to either avoid creating the one-time checkpoint again or to remove the existing one. **Description** Remove the existing one-time checkpoint if it already exists. --------- Co-authored-by: avilagaston9 <gaston.avila@lambdaclass.com> Co-authored-by: Gianbelinche <39842759+gianbelinche@users.noreply.github.com>
Update the path to the SP1 VKs
**Motivation** <!-- Why does this pull request exist? What are its goals? --> OZ's upgrade tools require the variables to be set in initializers and not in constructor/variable declaration. This should not be such a problem as it will always be initialized as 0, but with this change we avoid the tool error **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the project version from 5.0.0 to 6.0.0, updates the default bridge address, and modifies SP1 verification key handling to support two separate key variants.
- Version bump from 5.0.0 to 6.0.0 across all workspace packages
- Updated DEFAULT_BRIDGE_ADDRESS to a new deployment address
- Split SP1 verification keys into bn254 and u32 variants
- Fixed state variable initialization in CommonBridge contract to follow upgradeable contract best practices
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Bumped workspace version to 6.0.0 |
| Cargo.lock | Updated all ethrex package versions to 6.0.0 |
| crates/l2/prover/src/guest_program/src/sp1/Cargo.lock | Updated ethrex and guest_program package versions to 6.0.0 |
| crates/l2/prover/src/guest_program/src/risc0/Cargo.lock | Updated ethrex and guest_program package versions to 6.0.0 |
| crates/l2/sdk/src/sdk.rs | Updated DEFAULT_BRIDGE_ADDRESS to new deployment address |
| crates/l2/contracts/src/l1/CommonBridge.sol | Moved pendingPrivilegedTxIndex initialization from declaration to initialize() function |
| .github/workflows/tag_release.yaml | Updated to handle two separate SP1 verification key files (bn254 and u32) |
| .github/workflows/pr-main_l2.yaml | Updated to create placeholder files for both SP1 verification key variants |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
**Motivation** <!-- Why does this pull request exist? What are its goals? --> **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #issue_number --------- Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com> Co-authored-by: avilagaston9 <gaston.avila@lambdaclass.com> Co-authored-by: Gianbelinche <39842759+gianbelinche@users.noreply.github.com> Co-authored-by: ilitteri <ilitteri@fi.uba.ar>
Motivation
Description
Closes #issue_number