Add PHP 8.5 #181
Merged
Add PHP 8.5 #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for lando-php failed. Why did it fail? →
|
todeveni
reviewed
Nov 22, 2025
images/8.5-apache/Dockerfile
Outdated
| #RUN install-php-extensions xdebug \ | ||
| # && rm -f /usr/local/etc/php/conf.d/*xdebug.ini | ||
|
|
||
| # Install xdebug from source while there's no compatible PECL release. |
There was a problem hiding this comment.
You can install Xdebug from Github using install-php-extensions xdebug/xdebug@master
Contributor
Author
There was a problem hiding this comment.
Oh, I didn't know it could work like that. I changed it to the suggested simpler one.
todeveni
reviewed
Nov 22, 2025
images/8.5-apache/Dockerfile
Outdated
| && docker-php-ext-enable xdebug \ | ||
| && rm -f /usr/local/etc/php/conf.d/*xdebug.ini | ||
|
|
||
| # Install imagick from source while there's no compatible PECL release. |
There was a problem hiding this comment.
And same goes here. You can install Imagick from Github using install-php-extensions imagick/imagick@master
Contributor
Author
There was a problem hiding this comment.
I changed it to that.
AaronFeledy
approved these changes
Nov 25, 2025
Member
|
Thanks for doing this @kaszarobert, this looks good. Thanks for reviewing @todeveni. The test failures are expected since you don't have our Docker Hub credentials. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #180
Based on how 8.4 is set I added 8.5 with the same settings and extensions.
xdebug and imagick don't have PECL releases that install with PHP 8.5 yet so I had to comment out those lines and install them from source.
Bare minimum self-checks
mainPieces of flare
Finally
If you have any issues or need help please join the
#contributorschannel in the Lando slack and someone will gladly help you out!You can also check out the coder guide.