Skip to content

Conversation

@ejscribner
Copy link

Overview

Type of change

Type: New documentation page

Related issues/PRs

  • Linear issue:
  • Slack thread:

Checklist

  • I have read the contributing guidelines
  • I have tested my changes locally using docs dev
  • All code examples have been tested and work correctly
  • I have used root relative paths for internal links
  • I have updated navigation in src/docs.json if needed
  • I have gotten approval from the relevant reviewers

Additional notes

@github-actions github-actions bot added langchain For docs changes to LangChain oss javascript labels Oct 21, 2025
@ejscribner ejscribner force-pushed the couchbase-query-vector-docs branch from 44f9441 to a45f8e0 Compare October 22, 2025 20:01
@ejscribner ejscribner force-pushed the couchbase-query-vector-docs branch from 6edfde6 to 17b9ade Compare October 22, 2025 23:21
@ejscribner ejscribner marked this pull request as ready for review October 22, 2025 23:23
Copilot AI review requested due to automatic review settings October 22, 2025 23:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for the new CouchbaseQueryVectorStore implementation and refactors existing Couchbase vector store documentation to distinguish between two different approaches: the Query-based implementation (new, preferred) and the Search-based implementation (existing). The changes clarify that Couchbase now offers two methods for vector search using different services.

Key changes:

  • Adds comprehensive documentation for CouchbaseQueryVectorStore including setup, usage, indexing options, and comparisons
  • Renames existing Couchbase documentation to couchbase_search.mdx to reflect its use of the Search Service
  • Updates navigation and card references to distinguish between "Couchbase Query" and "Couchbase Search"

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/oss/javascript/integrations/vectorstores/index.mdx Updates card titles and links to distinguish between Query and Search implementations
src/oss/javascript/integrations/vectorstores/couchbase_search.mdx Refines title and clarifies this implementation uses the Search Service
src/oss/javascript/integrations/vectorstores/couchbase_query.mdx New comprehensive documentation page for the Query-based vector store implementation
src/oss/javascript/integrations/providers/all_providers.mdx Updates provider cards to show both Query (recommended) and Search implementations

Copilot AI review requested due to automatic review settings October 24, 2025 19:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comment on lines +260 to +261
- `DistanceStrategy.L2` - L2 (Euclidean) distance
- `DistanceStrategy.EUCLIDEAN` - Euclidean distance
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 260 and 261 both describe the same distance metric (Euclidean distance). Having both L2 and EUCLIDEAN listed separately with the same description is confusing for users. Please clarify if these are truly identical or if there are subtle implementation differences that should be documented.

Suggested change
- `DistanceStrategy.L2` - L2 (Euclidean) distance
- `DistanceStrategy.EUCLIDEAN` - Euclidean distance
- `DistanceStrategy.L2`/`DistanceStrategy.EUCLIDEAN` - Euclidean (L2) distance

Copilot uses AI. Check for mistakes.
Comment on lines +263 to +264
- `DistanceStrategy.L2_SQUARED` - Squared L2 distance
- `DistanceStrategy.EUCLIDEAN_SQUARED` - Squared Euclidean distance
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the previous issue, L2_SQUARED and EUCLIDEAN_SQUARED appear to be redundant entries describing the same metric. Consider consolidating these or explicitly documenting any differences between the two strategies.

Suggested change
- `DistanceStrategy.L2_SQUARED` - Squared L2 distance
- `DistanceStrategy.EUCLIDEAN_SQUARED` - Squared Euclidean distance
- `DistanceStrategy.L2_SQUARED` - Squared L2 (Euclidean) distance

Copilot uses AI. Check for mistakes.
@mdrxy mdrxy requested a review from hntrl October 29, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript langchain For docs changes to LangChain oss

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants