Make it possible to specify superuser, superuserPassword and secretKey securely using Kubernetes Secrets#55
Open
srinathh wants to merge 5 commits intolangflow-ai:mainfrom
Open
Make it possible to specify superuser, superuserPassword and secretKey securely using Kubernetes Secrets#55srinathh wants to merge 5 commits intolangflow-ai:mainfrom
srinathh wants to merge 5 commits intolangflow-ai:mainfrom
Conversation
currently, the superuser, superuserPassword & secretKey are directly pulled as values into the backend chart. This prevents us from using Kubernetes Secrets for these values and instead requires them to be hard coded in values.yaml. This change allows Kubernetes Secrets to be used similar to how externaldb envs are handled
make specifying superuserPassword & secretKey more secure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54
Currently in backend-statefulset.yaml, parameters from value.yaml are directly copied into value. This prevents Kubernetes Secrets from being used & instead requires hard-coding these into values.yaml. With this implementaion, if we use Kubernetes Secrets in values.yaml, a string representation of the yaml gets copied over instead of the correct reference.
Database settings are correctly handled and implementing this style will let secrets be used for superuser as well
Additionally, setting admin password as a random default is worse than useless as then no one can ever login. It should not be optional. Similarly, SecretKey is ideally not optional if autologin is provided
This fix implements the same style as used in Database settings to superuser