fix: aws connection is failing in OpenRAG version 0 4 0 dev5#1231
Open
ricofurtado wants to merge 1 commit intorelease-0.4.0from
Open
fix: aws connection is failing in OpenRAG version 0 4 0 dev5#1231ricofurtado wants to merge 1 commit intorelease-0.4.0from
ricofurtado wants to merge 1 commit intorelease-0.4.0from
Conversation
- Implement `verify_s3_credentials` to validate AWS S3 credentials. - Update `S3Connector.authenticate` to use the new verification method. - Add unit tests for `verify_s3_credentials` covering various scenarios.
2 tasks
edwinjosechittilappilly
requested changes
Mar 24, 2026
Collaborator
edwinjosechittilappilly
left a comment
There was a problem hiding this comment.
Rico can you check with QA team . that S3 and COS would have been missing since we disabled it for OpenSource and works only in IBM cloud deployments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verify_s3_credentialsto validate AWS S3 credentials.S3Connector.authenticateto use the new verification method.verify_s3_credentialscovering various scenarios.There is a behaviour question(maybe product can anwer it):
If the credentials are valid but don’t have s3:ListAllMyBuckets, “Test connection” should still succeed?
In this case, the UI should not block saving just because bucket listing failed.
If bucket listing is unavailable, do we need to explain why in plain terms? E.g. “Credentials are valid, but this IAM user can’t list all buckets. Enter/select bucket names manually.”
-After saving, the connection should only be treated as usable if it has either:
ListBuckets permission, so auto-discovery can work, or
explicit bucket_names, so the connector can operate without bucket discovery.
So the practical fix is to split today’s combined step into two states: