Skip to content

fix: make onboarding not loop when error occurs in ingestion, fix double tasks for OpenRAG docs#1248

Merged
lucaseduoli merged 1 commit intomainfrom
fix/onboarding_loop
Mar 24, 2026
Merged

fix: make onboarding not loop when error occurs in ingestion, fix double tasks for OpenRAG docs#1248
lucaseduoli merged 1 commit intomainfrom
fix/onboarding_loop

Conversation

@lucaseduoli
Copy link
Collaborator

This pull request introduces significant improvements to the onboarding rollback process and document ingestion logic, with a focus on enhanced cleanup, configurability, and consistency in connector types. The main changes include allowing partial rollback of onboarding (embedding-only), ensuring knowledge filters are cleaned up during rollback, purging tasks more thoroughly, and standardizing connector types for document ingestion tasks. Additionally, the ingestion pipeline now consistently returns task IDs and supports reusing existing tasks.

Onboarding Rollback Improvements:

  • Added support for partial onboarding rollback (embedding-only) by introducing an embedding_only parameter in both the frontend (RollbackParams) and backend (RollbackBody), allowing users to roll back only the embedding step without resetting all onboarding progress. [1] [2] [3]
  • Enhanced backend rollback logic to clean up knowledge filters created during onboarding and to fully purge tasks from memory for both authenticated and anonymous users, improving system hygiene and preventing stale data. [1] [2]

Frontend Integration:

  • Updated all calls to the rollback mutation in the onboarding UI to pass the embedding_only flag, ensuring the correct rollback mode is triggered based on user context. [1] [2]

Document Ingestion Pipeline Enhancements:

  • Refactored ingestion functions to consistently return task IDs, enabling better tracking and chaining of ingestion steps. Added support for passing existing_task_id through the pipeline to reuse tasks when appropriate. [1] [2] [3] [4] [5] [6] [7] [8]
  • Standardized the connector_type used for document ingestion tasks to "openrag_docs" instead of "system_default" or "local", improving traceability and consistency across different ingestion methods. [1] [2] [3] [4] [5]

Other Improvements:

  • Minor UI logic fixes and code formatting for onboarding steps and error handling.
  • Ensured that error toasts for failed tasks are only shown if onboarding is not active, preventing redundant or confusing notifications.

These changes collectively make the onboarding and document ingestion flows more robust, maintainable, and user-friendly.

Closes #1243

…ble tasks for OpenRAG docs (#1244)

* Fixed default docs being ingested in separate tasks

* Added embedding_only prop to only rollback what is needed

* fix tasks menu opening when an error occurs in onboarding

* Clean tasks, filters and etc on onboarding

* Fixed URL docs not being ingested with right type

* Fixed default openrag docs being ingested along with URL docs

* Fix delete knowledge on onboarding rollback
@lucaseduoli lucaseduoli requested a review from mfortman11 March 24, 2026 22:13
@lucaseduoli lucaseduoli self-assigned this Mar 24, 2026
@github-actions github-actions bot added frontend 🟨 Issues related to the UI/UX backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) bug 🔴 Something isn't working. labels Mar 24, 2026
@mpawlow mpawlow self-requested a review March 24, 2026 23:09
Copy link
Collaborator

@mpawlow mpawlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucaseduoli

Code Review 1

  • ✅ LGTM / Approved
  • Approved based on code review for duplicate PR already merged into main branch

@github-actions github-actions bot added the lgtm label Mar 24, 2026
@lucaseduoli lucaseduoli merged commit 8ed2879 into main Mar 24, 2026
12 checks passed
@github-actions github-actions bot deleted the fix/onboarding_loop branch March 24, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) bug 🔴 Something isn't working. frontend 🟨 Issues related to the UI/UX lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Onboarding loops when an error occurs when ingesting

2 participants