fix: make onboarding not loop when error occurs in ingestion, fix double tasks for OpenRAG docs#1248
Merged
lucaseduoli merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
…ble tasks for OpenRAG docs (#1244) * Fixed default docs being ingested in separate tasks * Added embedding_only prop to only rollback what is needed * fix tasks menu opening when an error occurs in onboarding * Clean tasks, filters and etc on onboarding * Fixed URL docs not being ingested with right type * Fixed default openrag docs being ingested along with URL docs * Fix delete knowledge on onboarding rollback
mpawlow
approved these changes
Mar 24, 2026
Collaborator
mpawlow
left a comment
There was a problem hiding this comment.
Code Review 1
- ✅ LGTM / Approved
- Approved based on code review for duplicate PR already merged into main branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the onboarding rollback process and document ingestion logic, with a focus on enhanced cleanup, configurability, and consistency in connector types. The main changes include allowing partial rollback of onboarding (embedding-only), ensuring knowledge filters are cleaned up during rollback, purging tasks more thoroughly, and standardizing connector types for document ingestion tasks. Additionally, the ingestion pipeline now consistently returns task IDs and supports reusing existing tasks.
Onboarding Rollback Improvements:
embedding_onlyparameter in both the frontend (RollbackParams) and backend (RollbackBody), allowing users to roll back only the embedding step without resetting all onboarding progress. [1] [2] [3]Frontend Integration:
embedding_onlyflag, ensuring the correct rollback mode is triggered based on user context. [1] [2]Document Ingestion Pipeline Enhancements:
existing_task_idthrough the pipeline to reuse tasks when appropriate. [1] [2] [3] [4] [5] [6] [7] [8]connector_typeused for document ingestion tasks to"openrag_docs"instead of"system_default"or"local", improving traceability and consistency across different ingestion methods. [1] [2] [3] [4] [5]Other Improvements:
These changes collectively make the onboarding and document ingestion flows more robust, maintainable, and user-friendly.
Closes #1243