Skip to content

Conversation

@Daniele-Tentoni
Copy link

This PR resolves #525. It adds a new variable ${path} to be used in tandem with ${host} to have more control over target inside sections. If I need a specific fine-grained personal access tokens for each distinct repository, I could create this pass store:

Password Store
├── github.com
│   └── daniele-tentoni
│       ├── pass-git-helper.git
│       └── vue-mtg-deck-tracker.git

And this config as catch all as last of my sections:

[*]
target=${host}/${path}

So when this tool receives the request DEBUG:root:Received request "['protocol=https\n', 'host=github.com\n', 'path=daniele-tentoni/pass-git-helper.git\n', 'wwwauth[]=Basic realm="GitHub"\n']" it know to do the right job selecting the right target in pass:

DEBUG:root:Section "github.com*" matches requested header "github.com/daniele-tentoni/password-store.git"
DEBUG:root:Requesting entry "github.com/daniele-tentoni/password-store.git" from pass

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.06%. Comparing base (d7550ca) to head (9cdd8b9).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
+ Coverage   91.97%   92.06%   +0.08%     
==========================================
  Files           1        1              
  Lines         187      189       +2     
  Branches       24       25       +1     
==========================================
+ Hits          172      174       +2     
  Misses         10       10              
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@languitar languitar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The implementation looks fine to me. Let's just obey to the commit convention so that a correct semver release is the result. Can you squash this down into a single commit of type feat?

@Daniele-Tentoni
Copy link
Author

@languitar sorry for the long delay. This commit message is right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to match path also to host part of url repo

3 participants