Conversation
Container: redefine p variants — xs=boxed (p-[min(3rem,5vw)]); sm/md/lg use px-[min(3rem,5vw)] with Section-scale vertical py.\nRefactors: update p usages to xs in split-media-07/08, cta-08, ContainerPrimaryBackgroundExample.\nDocs: update CONTRIBUTING.md to reflect new Container p API.\nNote: existing lg usages (cta-09, inverse/card examples) kept as-is.
…n UX - Changed all animation presets to use 'animate' instead of 'whileInView' - Removed viewport and whileInView references from MotionProps type - Updated helper functions to remove whileInView handling - Refactored code-02 and testimonials-05 to use ContentItems wrapper This fixes the issue where components wouldn't appear when navigating back to previously visited pages. Now animations play on mount and show final state on return visits. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Changed TextReveal04, TextReveal06, TextReveal07, TextReveal08 to export as TextReveal - Updated corresponding Props types from numbered versions to TextRevealProps - Fixed all example imports and JSX tags to use the generic TextReveal name - Follows the pattern where files use numbered names for registry but export generic names 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Changed title, subtitle, and eyebrow props from string to React.ReactNode across 100+ components
- Enables rich text formatting with spans, different colors, and inline components
- Used Omit utility type to resolve HTML attribute conflicts for title prop
- Preserved string types for navigation, structured data, and content frontmatter where appropriate
Example usage:
<Hero
title={
<>
Ship enterprise SSO{" "}
<span className="text-muted-foreground">in less than a day</span>
</>
}
/>
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR makes comprehensive type safety improvements and component refinements for SSOReady site finalization. The changes focus on converting string-typed display properties to more flexible React.ReactNode types and unifying animation patterns.
Key changes include:
- Updated component props to use
React.ReactNodeinstead ofstringfortitle,subtitle, andeyebrowproperties across all section components - Standardized animation patterns by removing
whileInViewin favor ofanimatefor consistency - Enhanced component APIs by using
Omitutility types to prevent HTML attribute conflicts
Reviewed Changes
Copilot reviewed 144 out of 144 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| registry/new-york/section/* | Updated all section component interfaces to use React.ReactNode for display props and avoid HTML attribute conflicts |
| registry/new-york/navigation/* | Simplified navbar variants by removing unused variant system and props |
| registry/new-york/lib/animation-presets.ts | Standardized animation API by removing whileInView and using animate consistently |
| registry/new-york/layout/container.tsx | Updated padding system with more specific responsive values |
| registry/new-york/effects/text-reveal-*.tsx | Unified component naming from specific numbered exports to generic TextReveal |
| examples/* | Updated component usage to match new simplified APIs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 144 out of 144 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.