Open
Conversation
lanurmi
force-pushed
the
silence-c4265
branch
from
dc409ef to
676f30b
Compare
Explicitly defining a destructor in wxMSWOwnerDrawnButtonBase causes precisely the kind of compiler warnings (C4265) that the definition was meant to suppress on GCC. C4265 is not enabled by default in VC++, but if you have it enabled, you'll get plenty of pointless warnings through anything that #includes wx/msw/ownerdrawnbutton.h. This is also the only spot in wx headers that triggers C4265. The issue appears to be 3.2-specific.
lanurmi
force-pushed
the
silence-c4265
branch
from
676f30b to
6a21bee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was caused by code that was added to silence similar warning on GCC.
Does this break ABI?