Add AGENTS.md file #303
Open
Add AGENTS.md file #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avosalmon
reviewed
Nov 21, 2025
AGENTS.md
Outdated
| ## Code Style & Formatting | ||
|
|
||
| - **Use Laravel Pint** with the project's configuration (`pint.json`) | ||
| - **Strict typing**: Always use type hints for parameters and return types |
Contributor
There was a problem hiding this comment.
Not sure if we need this when it's also mentioned in the Type Safety section.
AGENTS.md
Outdated
| - Use `Location` helper for file/line detection | ||
| - Use `Clock` for timestamp management | ||
| - **Check property visibility**: Before using reflection, verify if Laravel properties are public. Prefer direct property access over reflection when possible. | ||
| - **Trust Laravel validation**: If Laravel validates a value, trust that validation rather than re-validating in our code |
Contributor
There was a problem hiding this comment.
I'm not sure what kind of validations this refers to 🤔
Member
Author
There was a problem hiding this comment.
My agent wrote a lot of defensive code around the repeatSeconds property when I was testing it out on #302. I asked it to update it's context to prevent that when the value is coming from Laravel itself. It is a little misleading given that validation is a separate concept in Laravel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a base set of agent guidelines for the project. The guidelines were agent-generated from our existing code, and then further refined until they were able to complete a basic task to an acceptable standard (See #302).