Skip to content

[1.x] Supports PHP 8.4 #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taylorotwell merged 3 commits into from
Nov 21, 2024
Merged

[1.x] Supports PHP 8.4 #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d67772
[1.x] Supports PHP 8.4
crynobone Nov 12, 2024
c334981
wip
crynobone Nov 21, 2024
29e3d96
wip
crynobone Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ jobs:
php: [8.1, 8.2, 8.3]
laravel: [10, 11]
stability: [prefer-lowest, prefer-stable]
include:
- php: 8.4
laravel: 11
stability: prefer-stable

name: PHP ${{ matrix.php }} - Laravel ${{ matrix.laravel }} - Stability ${{ matrix.stability }} - MySQL 5.7

Expand All @@ -55,9 +59,13 @@ jobs:
- name: Install redis-cli
run: sudo apt-get install -qq redis-tools

- name: Install dependencies
- name: Require cachewerk/relay
run: |
composer require cachewerk/relay --no-interaction --no-update
if: matrix.php != 8.4

- name: Install dependencies
run: |
composer update --prefer-dist --no-interaction --no-progress --${{ matrix.stability }}

- name: Execute tests
Expand Down Expand Up @@ -114,9 +122,13 @@ jobs:
- name: Install redis-cli
run: sudo apt-get install -qq redis-tools

- name: Install dependencies
- name: Require cachewerk/relay
run: |
composer require cachewerk/relay --no-interaction --no-update
if: matrix.php != 8.4

- name: Install dependencies
run: |
composer update --prefer-dist --no-interaction --no-progress --${{ matrix.stability }}

- name: Execute tests
Expand Down Expand Up @@ -171,11 +183,14 @@ jobs:
- name: Install redis-cli
run: sudo apt-get install -qq redis-tools

- name: Install dependencies
- name: Require cachewerk/relay
run: |
composer require "illuminate/contracts=^${{ matrix.laravel }}" --dev --no-update
composer require cachewerk/relay --no-interaction --no-update
composer update --prefer-dist --no-interaction --no-progress
if: matrix.php != 8.4

- name: Install dependencies
run: |
composer update --prefer-dist --no-interaction --no-progress --${{ matrix.stability }} --with="illuminate/contracts=^${{ matrix.laravel }}"

- name: Execute tests
run: vendor/bin/pest -vvv
Expand Down Expand Up @@ -220,9 +235,13 @@ jobs:
- name: Install redis-cli
run: sudo apt-get install -qq redis-tools

- name: Install dependencies
- name: Require cachewerk/relay
run: |
composer require cachewerk/relay --no-interaction --no-update
if: matrix.php != 8.4

- name: Install dependencies
run: |
composer update --prefer-dist --no-interaction --no-progress --${{ matrix.stability }}

- name: Execute tests
Expand Down
2 changes: 2 additions & 0 deletions src/Storage/DatabaseStorage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,7 @@ protected function periods(): array
*/
public function values(string $type, ?array $keys = null): Collection
{
/** @phpstan-ignore return.type */
return $this->connection()
->table('pulse_values')
->select('timestamp', 'key', 'value')
Expand Down Expand Up @@ -529,6 +530,7 @@ public function aggregate(

$orderBy ??= $aggregates[0];

/** @phpstan-ignore return.type */
return $this->connection()
->query()
->select([
Expand Down